Repository navigation
feat(catalog): add env-secrets-guard skill - #180
Merged
OdevMatheus merged 1 commit intoNov 9, 2026
Merged
Conversation
Add an arch-quality skill that detects hardcoded credentials, .env files tracked by git and .env files missing from .gitignore through a stdlib-only scanner (scripts/scan_secrets.py, --json, exit codes 0/1/2, redacted output). Update catalog-count assertions in the existing tests and add a changelog entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
OdevMatheus
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
env-secrets-guardskill (arch-qualitytrack). It helps agents catch credential leaks before a commit or push:secret,password,api_key, ...).env*files that are tracked by git or not covered by.gitignoreThe Level 3 script
scripts/scan_secrets.pyuses only the Python standard library, supports--json, exits0(clean),1(findings) or2(invalid path), never reads the content of real.env*files, and redacts matches to a 4-character prefix.Closes #
N/A (Catalog contribution, Track A)
Contribution Track & Type of Change
catalog/): New or updated Skill (SKILL.md) or Subagent (SUBAGENT.md) (Issue optional)src/,.github/,docs/): CLI, TUI, transpiler, tests, or infrastructure (Issue required)Pre-Flight & Governance Checklist
catalog/(Track A). The only other edits are catalog-count assertions in two existing tests and aCHANGELOG.mdentry.en-US)SKILL.mddescription is 56 words, starts with "Use when...", includes negative triggers; body is 60 lines (INV-SKILL-01).node dist/cli.js add env-secrets-guard --targets all --dry-runplans 41 files across the 28 targets.npm run lint,npm test(16/16) andnpm run buildpass locally.Notes for reviewers
evals/benchmark.jsonis included, on purpose.SKILL_CONTRACT.mdlists it, but theevalrunner was removed in refactor(cli): strip secondary commands and keep only add and remove #158 and the CLI now only exposesaddandremove. The old runner (src/eval/index.tsbefore refactor(cli): strip secondary commands and keep only add and remove #158) does not execute any agent: it validates a pre-writtenbenchmark.json, or, when the file is missing, falls back to hardcoded values (0.95vs0.62). I did not want to commit numbers that were not measured, so this skill hasevals/evals.json(3 scenarios, schema-valid) but no benchmark. A real with/without-skill measurement could be a follow-up.tests/npx_core.test.tsandtests/router_sync.test.tshardcoded the catalog size (1 skill, 1 subagent). I updated the counts and the expected order, since any new catalog entry would break them. Making those assertions independent of the catalog contents could be a separate cleanup.🤖 Generated with Claude Code