Repository navigation
Conversation
foundryup skips its hash check for releases without attestations, which includes v1.0.0. The tarball digest supersedes the installer pin.
mglowack
approved these changes
Oct 21, 2026
eljobe
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
foundryupin therollupcreatorimage with a direct download of the Foundry v1.0.0 release tarball, checked against a pinned per-arch sha256. Currentlyfoundryupskips its hash check for releases without attestations, which includes v1.0.0. A replaced release asset would go into the image unnoticed. The version stays because a Foundry bump can change the compiled contracts, which belongs in its own change.foundryupinstaller pin from Pin the foundryup installer in the rollupcreator image #212, which the tarball digest supersedesBuilds on linux/amd64 and arm64 run all four binaries at 1.0.0. A wrong digest fails at
sha256sum -c.Part of NIT-6079