Repository navigation
feat(chat): show the player head before the prefix in chat - #138
Merged
Merged
Conversation
Contributor
Test results 38 files 38 suites 25s ⏱️ Results for commit e789b66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:and the message, on Paper and Minestom.Player#getSkin(); without textures it is sent with UUID and name only. Names Adventure rejects as head names (e.g. Bedrock names with spaces) are omitted so chat never fails.butterfly.chat.head.enabled(defaulttrue), added to both bundleddefault-config.yamlfiles; invalid values fall back to the default with a warning.ChatLine/PlayerHeadshelpers inapi.OpenSpec
replace-togglz-with-avaje-configandrestrict-chat-tags-by-permission.add-player-head-to-chat.Tests
PlayerHeadsTest(5),ChatLineTest(4), 3 newButterflySettingsTestcases, Minestom chat/head/config tests; 143 tests inapiandminestomin total../gradlew build :minestom:smokeTestgreen.Manual test
Paper 26.2, LuckPerms 5.5.71, ViaVersion/ViaBackwards 5.12.1, 26.2 client (build of 509a1fa):
config.yamlcreated on first start with all defaults (incl.chat.head.enabled), unchanged on second start (identical sha256).flags.propertiesin the server root: one warning, ignored.sort-format"%02d"gives team01default; key removed with-Dbutterfly.format=%03dgives001default; default gives0001default.<red>rot <click:run_command:/help>klick</click>stays literal; afterlp group default permission set butterfly.chat.tag.color truethe text is red and the<click>tag stays literal.[Test]prefix with the player's skin; withbutterfly.chat.head.enabled: falsethere is no head and no leading space.Before merge
https://claude.ai/code/session_01Wt7kcAoVtZTEALDSX4CxWF