Repository navigation
[projmgr] Add trace configuration schema and file node handling - #2700
Conversation
Test Results 2 files - 43 14 suites - 153 12m 6s ⏱️ - 8m 12s Results for commit 3107895. ± Comparison against base commit 839502c. This pull request removes 1278 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
244dc2c to
1810971
Compare
1810971 to
2d56aa5
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Adapter trace defaults can overwrite explicit target-set trace settings, discarding user transports and resolved file paths and failing to honor explicit empty-list overrides.
1 open issue
What changed in this PR
Adds trace configuration support to the project manager, addressing issue #732 by extending YAML schemas and resolving trace output paths for generated cbuild-run files.
Changes:
- Adds optional trace settings while allowing custom properties and additional mode values.
- Parses trace entries, resolves file paths, and emits trace configuration.
- Adds conversion tests for output locations, optional fields, and invalid access sequences.
| File | Description |
|---|---|
| tools/projmgr/test/src/ProjMgrUnitTests.cpp | Tests trace conversion and invalid access sequences. |
| tools/projmgr/test/data/TestRunDebug/trace.csolution.yml | Provides file- and server-mode trace fixtures. |
| tools/projmgr/test/data/TestRunDebug/trace.cproject.yml | Provides the trace test project. |
| tools/projmgr/src/ProjMgrYamlParser.cpp | Parses trace files separately from custom settings. |
| tools/projmgr/src/ProjMgrWorker.cpp | Resolves trace file paths and access sequences. |
| tools/projmgr/src/ProjMgrCbuildRun.cpp | Emits trace entries with formatted file paths. |
| tools/projmgr/schemas/common.schema.json | Defines extensible trace configuration schemas. |
| tools/projmgr/include/ProjMgrYamlParser.h | Declares the trace key and parsing method. |
| tools/projmgr/include/ProjMgrWorker.h | Adds trace entries to processed debugger data. |
| tools/projmgr/include/ProjMgrParser.h | Defines trace items and stores parsed entries. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
+ Coverage 87.53% 87.55% +0.01%
==========================================
Files 208 208
Lines 33657 33685 +28
==========================================
+ Hits 29462 29492 +30
+ Misses 4195 4193 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|

Fixes
trace:node and childs to the input YAML schema with links to documentation cmsis-toolbox#732Changes
Checklist