Skip to content

[projmgr] Add trace configuration schema and file node handling - #2700

Merged
brondani merged 2 commits into
mainfrom
projmgr-add-trace-configuration
Nov 11, 2026
Merged

brondani merged 2 commits into
mainfrom
projmgr-add-trace-configuration

Conversation

@brondani

@brondani brondani commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Add schema definitions for trace configuration options, keeping the schema permissive and extensible by allowing additional properties and enum values, with all nodes optional (no required fields).
  • Parse, resolve and emit trace file paths.
  • Add a unit test covering trace output conversion.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Test Results

  2 files   -    43   14 suites   - 153   12m 6s ⏱️ - 8m 12s
495 tests  - 1 277  495 ✅  - 1 260  0 💤  - 17  0 ❌ ±0 
990 runs   - 3 254  990 ✅  - 3 185  0 💤  - 69  0 ❌ ±0 

Results for commit 3107895. ± Comparison against base commit 839502c.

This pull request removes 1278 and adds 1 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
ProjMgrUnitTests ‑ TestRunDebugTrace

♻️ This comment has been updated with latest results.

@brondani
brondani force-pushed the projmgr-add-trace-configuration branch 2 times, most recently from 244dc2c to 1810971 Compare November 10, 2026 16:35
@brondani
brondani force-pushed the projmgr-add-trace-configuration branch from 1810971 to 2d56aa5 Compare November 11, 2026 10:08
@brondani
brondani requested a balanced review from Copilot November 11, 2026 11:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Adapter trace defaults can overwrite explicit target-set trace settings, discarding user transports and resolved file paths and failing to honor explicit empty-list overrides.

1 open issue
What changed in this PR

Adds trace configuration support to the project manager, addressing issue #732 by extending YAML schemas and resolving trace output paths for generated cbuild-run files.

Changes:

  • Adds optional trace settings while allowing custom properties and additional mode values.
  • Parses trace entries, resolves file paths, and emits trace configuration.
  • Adds conversion tests for output locations, optional fields, and invalid access sequences.
File Description
tools/​projmgr/​test/​src/​ProjMgrUnitTests.cpp Tests trace conversion and invalid access sequences.
tools/​projmgr/​test/​data/​TestRunDebug/​trace.csolution.yml Provides file- and server-mode trace fixtures.
tools/​projmgr/​test/​data/​TestRunDebug/​trace.cproject.yml Provides the trace test project.
tools/​projmgr/​src/​ProjMgrYamlParser.cpp Parses trace files separately from custom settings.
tools/​projmgr/​src/​ProjMgrWorker.cpp Resolves trace file paths and access sequences.
tools/​projmgr/​src/​ProjMgrCbuildRun.cpp Emits trace entries with formatted file paths.
tools/​projmgr/​schemas/​common.schema.json Defines extensible trace configuration schemas.
tools/​projmgr/​include/​ProjMgrYamlParser.h Declares the trace key and parsing method.
tools/​projmgr/​include/​ProjMgrWorker.h Adds trace entries to processed debugger data.
tools/​projmgr/​include/​ProjMgrParser.h Defines trace items and stores parsed entries.

Review effort: Balanced

Comment thread tools/projmgr/src/ProjMgrCbuildRun.cpp Resolved
@brondani
brondani marked this pull request as ready for review November 11, 2026 14:14
@brondani
brondani requested a review from edriouk November 11, 2026 14:15
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (839502c) to head (3107895).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
+ Coverage   87.53%   87.55%   +0.01%     
==========================================
  Files         208      208              
  Lines       33657    33685      +28     
==========================================
+ Hits        29462    29492      +30     
+ Misses       4195     4193       -2     
Flag Coverage Δ
projmgr-cov 95.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrParser.h 100.00% <ø> (ø)
tools/projmgr/include/ProjMgrWorker.h 90.32% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildRun.cpp 99.23% <100.00%> (+0.02%) ⬆️
tools/projmgr/src/ProjMgrRunDebug.cpp 97.70% <100.00%> (+0.02%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 94.49% <100.00%> (+0.03%) ⬆️
tools/projmgr/src/ProjMgrYamlParser.cpp 91.76% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit 90c418b into main Nov 11, 2026
26 checks passed
@brondani
brondani deleted the projmgr-add-trace-configuration branch November 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants