Repository navigation
[projmgr] Include active MLOps contexts in pack resolution - #2701
Conversation
5848c6b to
c5b4aed
Compare
Test Results 2 files - 43 14 suites - 153 15m 23s ⏱️ - 1m 40s Results for commit 9a230c4. ± Comparison against base commit 90c418b. This pull request removes 1278 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
c5b4aed to
5613022
Compare
5613022 to
6ffe885
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Critical pack-resolution regressions can omit simulator board/device packs from the lock file, bypassing frozen-pack checks, and break hardware conversion under the default loading policy.
3 open issues
What changed in this PR
This PR addresses #2623 by extending pack resolution to contexts used by enabled MLOps hardware and simulator targets, alongside explicitly selected build contexts.
Changes:
- Track pack-relevant contexts separately from selected build contexts.
- Include additional MLOps contexts in pack loading, missing-pack reporting, and lock/index generation.
- Add tests for context refresh, selection changes, missing packs, and frozen-pack behavior.
| File | Description |
|---|---|
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp |
Tests pack-context refresh, reselection, and clearing. |
tools/projmgr/test/src/ProjMgrUnitTests.cpp |
Tests MLOps pack resolution and generated files. |
tools/projmgr/test/data/MLOps/pack_contexts.csolution.yml |
Adds active and inactive target pack requirements. |
tools/projmgr/src/ProjMgrWorker.cpp |
Uses expanded contexts for pack collection and loading. |
tools/projmgr/src/ProjMgrMlops.cpp |
Collects contexts from MLOps target sets. |
tools/projmgr/src/ProjMgrCbuildPack.cpp |
Includes additional contexts in pack-lock generation. |
tools/projmgr/src/ProjMgrCbuildIdx.cpp |
Includes additional missing packs and diagnostics in the index. |
tools/projmgr/include/ProjMgrWorker.h |
Declares pack-context state and access methods. |
tools/projmgr/include/ProjMgrMlops.h |
Declares the MLOps context-collection method. |
Review effort: Balanced
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
+ Coverage 87.55% 87.57% +0.01%
==========================================
Files 208 208
Lines 33685 33744 +59
==========================================
+ Hits 29492 29550 +58
- Misses 4193 4194 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|


Fixes
target:adds additional target into scope on top of active target #2623Changes
Checklist