Skip to content

[projmgr] Include active MLOps contexts in pack resolution - #2701

Merged
brondani merged 2 commits into
mainfrom
mlops-context-selection
Nov 13, 2026
Merged

brondani merged 2 commits into
mainfrom
mlops-context-selection

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Include contexts selected by enabled MLOps hardware and simulator targets when collecting required packs, listing missing packs and generating cbuild-pack and cbuild-idx files.
  • Report missing-pack errors for those contexts while excluding inactive target contexts.
  • Add unit coverage for missing and resolved packs across active, explicitly selected, and inactive contexts.

Checklist

  • 🤖 This change is covered by unit tests.
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@brondani
brondani force-pushed the mlops-context-selection branch from 5848c6b to c5b4aed Compare November 11, 2026 16:14
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Test Results

  2 files   -    43   14 suites   - 153   15m 23s ⏱️ - 1m 40s
498 tests  - 1 275  498 ✅  - 1 258  0 💤  - 17  0 ❌ ±0 
996 runs   - 3 250  996 ✅  - 3 181  0 💤  - 69  0 ❌ ±0 

Results for commit 9a230c4. ± Comparison against base commit 90c418b.

This pull request removes 1278 and adds 3 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
ProjMgrUnitTests ‑ GenerateMLOps_PackContexts
ProjMgrWorkerUnitTests ‑ PackContextsRefresh
ProjMgrWorkerUnitTests ‑ PackContextsReselection

♻️ This comment has been updated with latest results.

@brondani brondani changed the title Include active MLOps contexts in pack resolution [projmgr] Include active MLOps contexts in pack resolution Nov 11, 2026
@brondani
brondani force-pushed the mlops-context-selection branch from c5b4aed to 5613022 Compare November 12, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical pack-resolution regressions can omit simulator board/device packs from the lock file, bypassing frozen-pack checks, and break hardware conversion under the default loading policy.

3 open issues
What changed in this PR

This PR addresses #2623 by extending pack resolution to contexts used by enabled MLOps hardware and simulator targets, alongside explicitly selected build contexts.

Changes:

  • Track pack-relevant contexts separately from selected build contexts.
  • Include additional MLOps contexts in pack loading, missing-pack reporting, and lock/index generation.
  • Add tests for context refresh, selection changes, missing packs, and frozen-pack behavior.
File Description
tools/​projmgr/​test/​src/​ProjMgrWorkerUnitTests.cpp Tests pack-context refresh, reselection, and clearing.
tools/​projmgr/​test/​src/​ProjMgrUnitTests.cpp Tests MLOps pack resolution and generated files.
tools/​projmgr/​test/​data/​MLOps/​pack_contexts.csolution.yml Adds active and inactive target pack requirements.
tools/​projmgr/​src/​ProjMgrWorker.cpp Uses expanded contexts for pack collection and loading.
tools/​projmgr/​src/​ProjMgrMlops.cpp Collects contexts from MLOps target sets.
tools/​projmgr/​src/​ProjMgrCbuildPack.cpp Includes additional contexts in pack-lock generation.
tools/​projmgr/​src/​ProjMgrCbuildIdx.cpp Includes additional missing packs and diagnostics in the index.
tools/​projmgr/​include/​ProjMgrWorker.h Declares pack-context state and access methods.
tools/​projmgr/​include/​ProjMgrMlops.h Declares the MLOps context-collection method.

Review effort: Balanced

Comment thread tools/projmgr/src/ProjMgrCbuildPack.cpp Resolved
Comment thread tools/projmgr/src/ProjMgrWorker.cpp Resolved
Comment thread tools/projmgr/src/ProjMgrCbuildIdx.cpp Resolved
@brondani
brondani marked this pull request as ready for review November 12, 2026 14:03
@brondani
brondani requested a review from edriouk November 12, 2026 14:03
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.57%. Comparing base (90c418b) to head (9a230c4).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrWorker.cpp 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
+ Coverage   87.55%   87.57%   +0.01%     
==========================================
  Files         208      208              
  Lines       33685    33744      +59     
==========================================
+ Hits        29492    29550      +58     
- Misses       4193     4194       +1     
Flag Coverage Δ
projmgr-cov 95.22% <96.20%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrWorker.h 90.62% <100.00%> (+0.30%) ⬆️
tools/projmgr/src/ProjMgr.cpp 93.70% <100.00%> (+<0.01%) ⬆️
tools/projmgr/src/ProjMgrCbuildIdx.cpp 99.41% <100.00%> (+0.05%) ⬆️
tools/projmgr/src/ProjMgrCbuildPack.cpp 100.00% <100.00%> (ø)
tools/projmgr/src/ProjMgrMlops.cpp 97.41% <100.00%> (+0.63%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 94.47% <90.32%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit 7b321e6 into main Nov 13, 2026
26 checks passed
@brondani
brondani deleted the mlops-context-selection branch November 13, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants