Repository navigation
[projmgr] Prevent access sequences from being treated as layer variables - #2703
Conversation
1d59a00 to
8491d99
Compare
Test Results 2 files - 43 14 suites - 153 16m 7s ⏱️ -56s Results for commit 8491d99. ± Comparison against base commit 90c418b. This pull request removes 1278 and adds 2 tests. Note that renamed tests count towards both. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change that distinguishes access-sequence paths from layer variables.
No open issues 🎉
What changed in this PR
This PR addresses #2269 by preventing access sequences in layer paths from being mistaken for layer variables, allowing missing paths to reach missing-file reporting.
Changes:
- Exclude access-sequence and pack-directory patterns from layer-variable detection.
- Add regression tests for these patterns and verify ordinary layer variables remain supported.
| File | Description |
|---|---|
| tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp | Tests access-sequence exclusion, missing-file reporting, and ordinary layer-variable resolution. |
| tools/projmgr/src/ProjMgrWorker.cpp | Filters access-sequence and pack-directory patterns out of layer-variable detection. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2703 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 208 208
Lines 33685 33687 +2
=======================================
+ Hits 29492 29494 +2
Misses 4193 4193
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Changes
Checklist