Skip to content

[projmgr] Prevent access sequences from being treated as layer variables - #2703

Merged
brondani merged 1 commit into
mainfrom
fix-layer-variable-access-sequence
Nov 13, 2026
Merged

brondani merged 1 commit into
mainfrom
fix-layer-variable-access-sequence

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Ignore layer variable names matching access-sequence or pack-directory patterns when parsing context layers.
  • Add tests covering supported access sequences and confirming ordinary layer variables are preserved.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@brondani
brondani force-pushed the fix-layer-variable-access-sequence branch from 1d59a00 to 8491d99 Compare November 12, 2026 14:17
@github-actions

Copy link
Copy Markdown

Test Results

  2 files   -    43   14 suites   - 153   16m 7s ⏱️ -56s
497 tests  - 1 276  497 ✅  - 1 259  0 💤  - 17  0 ❌ ±0 
994 runs   - 3 252  994 ✅  - 3 183  0 💤  - 69  0 ❌ ±0 

Results for commit 8491d99. ± Comparison against base commit 90c418b.

This pull request removes 1278 and adds 2 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
ProjMgrWorkerUnitTests ‑ ParseContextLayersExcludesAccessSequences
ProjMgrWorkerUnitTests ‑ ParseContextLayersPreservesLayerVariables

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the change that distinguishes access-sequence paths from layer variables.

No open issues 🎉

What changed in this PR

This PR addresses #2269 by preventing access sequences in layer paths from being mistaken for layer variables, allowing missing paths to reach missing-file reporting.

Changes:

  • Exclude access-sequence and pack-directory patterns from layer-variable detection.
  • Add regression tests for these patterns and verify ordinary layer variables remain supported.
File Description
tools/​projmgr/​test/​src/​ProjMgrWorkerUnitTests.cpp Tests access-sequence exclusion, missing-file reporting, and ordinary layer-variable resolution.
tools/​projmgr/​src/​ProjMgrWorker.cpp Filters access-sequence and pack-directory patterns out of layer-variable detection.

Review effort: Balanced

@brondani
brondani marked this pull request as ready for review November 12, 2026 15:15
@brondani
brondani requested a review from edriouk November 12, 2026 15:15
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (90c418b) to head (8491d99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2703   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files         208      208           
  Lines       33685    33687    +2     
=======================================
+ Hits        29492    29494    +2     
  Misses       4193     4193           
Flag Coverage Δ
projmgr-cov 95.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 94.50% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit 0d06e7a into main Nov 13, 2026
27 checks passed
@brondani
brondani deleted the fix-layer-variable-access-sequence branch November 13, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants