Skip to content

[projmgr] Compact config file listings - #2705

Merged
brondani merged 1 commit into
mainfrom
compact-verbose-config-file-output
Nov 13, 2026
Merged

brondani merged 1 commit into
mainfrom
compact-verbose-config-file-output

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Flatten the config-file information message into one line per file, including its base/update versions and component where available.
  • Update the unit test to verify the new output format.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

Copy link
Copy Markdown

Test Results

  2 files   -    43   14 suites   - 153   11m 34s ⏱️ - 6m 15s
495 tests  - 1 278  495 ✅  - 1 261  0 💤  - 17  0 ❌ ±0 
990 runs   - 3 256  990 ✅  - 3 187  0 💤  - 69  0 ❌ ±0 

Results for commit 66ffb72. ± Comparison against base commit 90c418b.

This pull request removes 1278 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the compact config-file output change.

No open issues 🎉

What changed in this PR

Makes the project manager’s verbose config-file output more compact, addressing #2657 while preserving version and component details.

Changes:

  • List each config file on one line, including its base version, update version when different, and component when available.
  • Simplify the message header and remove indentation.
  • Update the unit test to verify the flattened output.
File Description
tools/​projmgr/​test/​src/​ProjMgrUnitTests.cpp Update expected output to verify unindented, per-file lines.
tools/​projmgr/​src/​ProjMgrWorker.cpp Build individual file entries with version and component details.
tools/​projmgr/​src/​ProjMgr.cpp Use the compact header and print entries without indentation.

Review effort: Balanced

@brondani
brondani marked this pull request as ready for review November 13, 2026 09:21
@brondani
brondani requested a review from edriouk November 13, 2026 09:21
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (90c418b) to head (66ffb72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files         208      208           
  Lines       33685    33686    +1     
=======================================
+ Hits        29492    29493    +1     
  Misses       4193     4193           
Flag Coverage Δ
projmgr-cov 95.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgr.cpp 93.69% <100.00%> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 94.49% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit cb8aacb into main Nov 13, 2026
27 checks passed
@brondani
brondani deleted the compact-verbose-config-file-output branch November 13, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants