Repository navigation
Update yaml-cpp and cxxopts to fix CodeQL builds on Ubuntu 26.04 - #2706
Conversation
Test Results 5 files 39 suites 3m 34s ⏱️ Results for commit 4d2d18e. ♻️ This comment has been updated with latest results. |
yaml-cpp and cxxopts to fix CodeQL builds on Ubuntu 26.04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 208 208
Lines 33747 33748 +1
=======================================
+ Hits 29553 29554 +1
Misses 4194 4194
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔵 Needs a closer look
The omitted gitlink diffs and absent dependency sources prevent verification that both submodules pin the revisions required by the rebased YAML patch and new cxxopts exception API.
No open issues 🎉
What changed in this PR
Updates dependency integration to address CodeQL build failures with Ubuntu 26.04 and GCC 15, while retaining ubuntu-latest and preserving local YAML behavior.
Changes:
- Adapts YAML handling and command-line exception catches to the updated dependency APIs.
- Ports the yaml-cpp patch, adds regression tests, and removes the obsolete cxxopts patch.
- Updates third-party version, revision, and usage notices.
| File | Description |
|---|---|
tools/svdconv/SVDConv/src/ParseOptions.cpp |
Uses the updated cxxopts exception type. |
tools/projmgr/src/ProjMgrYamlParser.cpp |
Passes pointer and length to YAML null-string checks. |
tools/projmgr/src/ProjMgr.cpp |
Uses the updated cxxopts exception type. |
tools/packgen/src/PackGen.cpp |
Uses the updated cxxopts exception type. |
tools/packchk/src/ParseOptions.cpp |
Uses the updated cxxopts exception type. |
tools/ctrace/docs/THIRD_PARTY_NOTICES.md |
Updates dependency versions and pinned revisions. |
tools/buildmgr/cbuildgen/src/CbuildGen.cpp |
Uses the updated cxxopts exception type. |
LICENSE.md |
Updates dependency versions and usage listings. |
libs/ymltree/test/YmlTreeTest.cpp |
Adds regression coverage for patched YAML behavior and bounded writes. |
external/yaml-cpp.patch |
Ports local YAML customizations to the updated upstream APIs. |
external/cxxopts.patch |
Removes the help-spacing patch now included upstream. |
CMakeLists.txt |
Stops applying the removed cxxopts patch. |
Review effort: Balanced
Fixes
ubuntu-latestrunner migration reached this workflow on November 13, 2026.The workflow selects
ubuntu-latest. The successful November 10 run used Ubuntu 24.04.5 and GCC 13.3.0, whereas the latest failed run used Ubuntu 26.04.1 and GCC 15.2.0.The newer toolchain exposed missing direct
<cstdint>includes in two bundled dependencies:src/emitterutils.cppbecauseuint16_tis undeclared.include/cxxopts.hppbecauseuint8_tis undeclared, preventing cbuildgen compilation and causing additional cascading errors.In both cases, the compiler identifies
<cstdint>as the missing header. These dependency build failures stop the workflow before CodeQL analysis can run; they are not CodeQL security findings or transient runner failures.GitHub announced the staged migration in actions/runner-images#14748:
Changes
0.8.0to the latest release,yaml-cpp-0.9.0, pinned to56e3bb550c91fd7005566f19c079cb7a503223cf. This release already includes the required<cstdint>header.IsNullStringcalls to upstream's pointer-and-length APIs.v3.3.1, pinned to44380e5a44706ab7347f400698c703eb2a196202. This release includes the missing-header fix for GCC 15.external/cxxopts.patchand its CMake application: the custom-help spacing fix is already upstream.cxxopts::OptionExceptionwithcxxopts::exceptions::exceptionin cbuildgen, projmgr, packgen, packchk, and svdconv.ubuntu-latest; address the dependency compatibility issue rather than pinning the workflow to the older runner image.Checklist