Repository navigation
Conversation
With verifier.kind: surfaces, the record shorthand can name the surface its record comes from, so a contract that qualify and verify-run share can also read other tables for its frame and side records. Unset, effects (and so contract digests) are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abrichr
marked this pull request as ready for review
October 25, 2026 14:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
record:shorthand, whichqualifyandverify-runboth read, could only describe a record read through a single verifier. So a contract couldn't also read the other tables a save might touch: the frame saw only the record's own table. That's how the production OpenEMR referral contract missed stray writes to history, notes, allergies and insurance in the independent fault suite (Phase 0: 7/17).record.surfacenames the surface of akind: surfacesverifier the record is read from. Its checks are routed there, and the other surfaces are read for the frame and side records (#1570). Unset, effects and contract digests are unchanged.Tests:
tests/test_record_surface.py: a record read frompatientverifies; a stray row innotesrefutes; an unset surface leaves the effects unrouted.Draft: part of the Phase 0 fixes (#1570–#1572), which the candidate contract uses.
🤖 Generated with Claude Code