Repository navigation
feat: testing for actions PR 48 - #11
Open
seantronsen wants to merge 1 commit into
Open
seantronsen wants to merge 1 commit into
seantronsen wants to merge 1 commit into
Conversation
seantronsen
added this pull request to stack #8
October 15, 2026 18:08
seantronsen
marked this pull request as ready for review
October 15, 2026 18:10
Open
11 of 17 tasks
seantronsen
removed this pull request from stack #8
October 15, 2026 18:19
seantronsen
added this pull request to stack #12
October 15, 2026 18:20
Base automatically changed from
seantronsen/testing-pr-47
to
seantronsen/development
October 15, 2026 18:21
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
seantronsen
force-pushed
the
seantronsen/testing-pr-48
branch
from
October 15, 2026 18:21
5e356e4 to
2ff1df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important
lint-makefile-common(and so thelintgate) is expected to fail until OpenCHAMI/github-actions#48 is in a release. The job compares this repo'sMakefile.commonwith the copy in the latest github-actions release, and no release has one yet, so it fails with "No Makefile.common in OpenCHAMI/github-actions release …". That still tests the workflow: it shows the job runs, resolves the latest release to its commit SHA, and fails loudly with a clear message instead of passing. The match and drift paths can be checked once v4.0 is released.Testbed for OpenCHAMI/github-actions#48:
Makefile.commonand includes it fromMakefile.quadlet-renderstays a repo target (GoReleaser's hook calls it);CLEANFILESkeeps the oldcleanbehavior.lint-makefile-commonjob to thelintgate.lint-go,lint-ci,reuse,build-check-goreleaser,build-release-goreleaser(Renovate-tracked version pins).Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
🤖 Generated with Claude Code