Skip to content

feat: testing for actions PR 48 - #11

Open
seantronsen wants to merge 1 commit into
seantronsen/developmentfrom
seantronsen/testing-pr-48
Open

seantronsen wants to merge 1 commit into
seantronsen/developmentfrom
seantronsen/testing-pr-48

Conversation

@seantronsen

@seantronsen seantronsen commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Important

lint-makefile-common (and so the lint gate) is expected to fail until OpenCHAMI/github-actions#48 is in a release. The job compares this repo's Makefile.common with the copy in the latest github-actions release, and no release has one yet, so it fails with "No Makefile.common in OpenCHAMI/github-actions release …". That still tests the workflow: it shows the job runs, resolves the latest release to its commit SHA, and fails loudly with a clear message instead of passing. The match and drift paths can be checked once v4.0 is released.

Testbed for OpenCHAMI/github-actions#48:

  • Vendors Makefile.common and includes it from Makefile. quadlet-render stays a repo target (GoReleaser's hook calls it); CLEANFILES keeps the old clean behavior.
  • Adds the lint-makefile-common job to the lint gate.
  • Bumps pins to the PR head only for workflows #48 changes: lint-go, lint-ci, reuse, build-check-goreleaser, build-release-goreleaser (Renovate-tracked version pins).

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

🤖 Generated with Claude Code

@seantronsen seantronsen self-assigned this Oct 15, 2026
@seantronsen
seantronsen added this pull request to stack #8 October 15, 2026 18:08
@seantronsen
seantronsen marked this pull request as ready for review October 15, 2026 18:10
@seantronsen
seantronsen removed this pull request from stack #8 October 15, 2026 18:19
@seantronsen
seantronsen added this pull request to stack #12 October 15, 2026 18:20
Base automatically changed from seantronsen/testing-pr-47 to seantronsen/development October 15, 2026 18:21
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/testing-pr-48 branch from 5e356e4 to 2ff1df6 Compare October 15, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant