Repository navigation
Create packaging data - #1
Merged
Merged
Conversation
erl-hpe
marked this pull request as ready for review
October 7, 2026 19:50
seantronsen
requested changes
Oct 8, 2026
seantronsen
left a comment
Collaborator
There was a problem hiding this comment.
Good overall. Lots of nitpicks on my side.
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
erl-hpe
force-pushed
the
create-packaging-data
branch
from
October 9, 2026 19:47
b038be7 to
34245ba
Compare
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
erl-hpe
force-pushed
the
create-packaging-data
branch
3 times, most recently
from
October 12, 2026 13:30
3e9dd78 to
031614d
Compare
Collaborator
|
@erl-hpe Good work. In the future, please paste the commit hashes for each fix that addresses a change request during a review. Two change requests remain at the time of writing. |
…p-in Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create the packaging materials needed to make this a true decomposed wrapper repository for OpenCHAMI Postgres running in Quadlet mode.
This was tested by its github actions and also by deploying it with a modified version of OpenCHAMI release from which the postgres components had been removed. The only issue that arose that was not strictly backward compatible with the original OpenCHAMI Release deployment is that the postgres data volume is now being named
systemd-postgres-datainstead of simplypostgres-data. This will need to be addressed in the OpenCHAMI Quadlet deployment tool when this package starts to be used for deploying postgres instead of OpenCHAMI Release.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change