Skip to content

Create packaging data - #1

Merged
seantronsen merged 5 commits into
mainfrom
create-packaging-data
Oct 13, 2026
Merged

seantronsen merged 5 commits into
mainfrom
create-packaging-data

Conversation

@erl-hpe

@erl-hpe erl-hpe commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Description

Create the packaging materials needed to make this a true decomposed wrapper repository for OpenCHAMI Postgres running in Quadlet mode.

This was tested by its github actions and also by deploying it with a modified version of OpenCHAMI release from which the postgres components had been removed. The only issue that arose that was not strictly backward compatible with the original OpenCHAMI Release deployment is that the postgres data volume is now being named systemd-postgres-data instead of simply postgres-data. This will need to be addressed in the OpenCHAMI Quadlet deployment tool when this package starts to be used for deploying postgres instead of OpenCHAMI Release.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@erl-hpe
erl-hpe marked this pull request as ready for review October 7, 2026 19:50
@erl-hpe
erl-hpe requested a review from seantronsen October 7, 2026 19:51

@seantronsen seantronsen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall. Lots of nitpicks on my side.

Comment thread .github/workflows/stale.yaml
Comment thread packaging/common/systemd/postgres.container.d/10-defaults.conf
Comment thread packaging/common/systemd/postgres.container Outdated
Comment thread packaging/common/systemd/postgres.container Outdated
Comment thread packaging/common/systemd/postgres.container Outdated
Comment thread packaging/common/systemd/postgres.container.d/10-defaults.conf Outdated
Comment thread packaging/common/systemd/postgres.container.d/10-defaults.conf Outdated
Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/build.yaml
Comment thread README.md
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
@erl-hpe
erl-hpe force-pushed the create-packaging-data branch from b038be7 to 34245ba Compare October 9, 2026 19:47
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
@seantronsen

Copy link
Copy Markdown
Collaborator

@erl-hpe Good work. In the future, please paste the commit hashes for each fix that addresses a change request during a review.

Two change requests remain at the time of writing.

…p-in

Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>

@seantronsen seantronsen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seantronsen
seantronsen merged commit 6c7c93f into main Oct 13, 2026
9 checks passed
@seantronsen
seantronsen deleted the create-packaging-data branch October 13, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants