Repository navigation
Exact curved inset, repeated tool instances, arc-arc caps and near-linear planar subtracts - #47
Merged
Merged
Conversation
A public static for a closed line-and-arc region, insetting through the kernel's exact curved inset. Declared API diff: + static insetCurvedRegion2D(region: CurvedRegion2D, distance: number): CurvedRegion2D[]; The open line-and-arc path offset is left for its own issue.
…l; refuse a tool listed twice
… by-handle check O(1) A planar subtract validated its host on every classify call and compared every edge, ring, vertex and face with every other. It now validates once, keeps one cached-bounds classifier per body, and visits only box-near pairs in the original order, falling back to every pair when the margin is unbounded or the pair count passes a budget. The binding caches body type per shape and a verified handle to ogId map. Results are unchanged; the 300-hole perforated plate's section draws in 4.4 s (was 13 s).
Brings #44 (shallow crossings in planar region booleans), #45 (display bounds per graph revision) and #46 (faster curved subtracts, release idle display geometry). Conflicts: query/mod.rs keeps Classifier and FaceTrim; geom2d/tests/boolean2d.rs keeps the nearby_boxes, wide-cutter and near-collinear mitre tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
OpenGeometry.insetCurvedRegion2D(region, distance)insets a closed line-and-arc region through the kernel's exact curved inset.operatecall gets its own face keys. A tool listed twice is refused.mainis merged in (#44, #45, #46). Two conflicts, both kept from each side:query/mod.rs(ClassifierandFaceTrim) andgeom2d/tests/boolean2d.rs(the box-index, wide-cutter and near-collinear mitre tests).Checks on the merged branch
npm run buildnpm test(cargo)npm --prefix main run test:nodenpm run checktest:performancefailed once under a load average of 58; run alone it passes 3 of 3 (slider boolean about 4.1 ms against a 12.0 ms budget, slider tessellation about 1.5 ms against 1.8 ms).