Repository navigation
Restore green CI (lock, setuptools, UTF-8 reads, Fiji cache) - #35
Merged
Merged
Conversation
…rces as UTF-8, prepare the Fiji cache - uv.lock was stale against pyproject (0.3.4 version, roifile dev extra, zmqruntime range); regenerate it. - test_publisher_admission imports setuptools.build_meta in-process but dev did not require setuptools, so Python 3.11 runners used their bundled setuptools 65.5, which rejects the PEP 639 license string. Require setuptools>=77.0 in dev, matching build-system. - Read Python sources, pyproject and workflows with encoding="utf-8" in tests, and read atomic JSON as UTF-8; Windows defaulted to cp1252. - The imagej-runtime job never saved its bundle cache because the test session forbids downloads and the job always failed on a cold cache. Materialize the declared bundle in a step before pytest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Tests workflow has been red since 2026-10-08 (run 37782748309); these are defects in main, not in #33/#34.
uv.lockwas never regenerated after pyproject changed (0.3.4,roifiledev extra,zmqruntimerange). Relocked.test_publisher_admissionbuilds the editable wheel with the in-processsetuptools, butdevdid not require setuptools, so 3.11 runners used their bundled setuptools 65.5.0 (pulled in unpinned via genbadge), which rejects the PEP 639license = "MIT"string.devnow requiressetuptools>=77.0, matchingbuild-system.encoding="utf-8"(fiji_stream.py holds non-cp1252 bytes).atomic._read_json_or_defaultreads UTF-8 too.tests/conftest.pyforbids downloads, and actions/cache only saves on success, so the bundle cache was never populated. A step now materializes the declared Fiji bundle before pytest; the live test itself is unchanged.🤖 Generated with Claude Code