Skip to content

B6: startup owner through the held lock on Windows (0.6.2); docs members derived - #29

Merged
trissim merged 3 commits into
mainfrom
b6-docs
Oct 12, 2026
Merged

trissim merged 3 commits into
mainfrom
b6-docs

Conversation

@trissim

@trissim trissim commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Part of OpenHCS surface B6 (main's CI green, OpenHCSDev/openhcs#1195).

  • docs/source/api/viewer_protocol.rst listed :members: by hand and still named ViewerComponentMode, ViewerComponentModeGroups and viewer_component_mode_value after L3 removed them, so the OpenHCS Documentation workflow's sphinx -W build failed. autodoc now derives the members from the module.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 11, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim trissim changed the title B6: docs and Windows startup-lock fixes for OpenHCS CI B6: startup owner through the held lock on Windows (0.6.1); docs members derived Oct 11, 2026
trissim added a commit to OpenHCSDev/openhcs that referenced this pull request Oct 11, 2026
…fest names ResolvedPipelineDefinition

Lockstep with OpenHCSDev/ZMQRuntime#29.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim added a commit to OpenHCSDev/openhcs that referenced this pull request Oct 11, 2026
On Windows portalocker locks are mandatory, so startup_owner's second handle
on the lock file raised PermissionError in every Windows ZMQ test. Lockstep with
OpenHCSDev/ZMQRuntime#29; pypi-dependency-readiness needs v0.6.1 tagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim and others added 3 commits October 11, 2026 12:12
The hand-written :members: list still named ViewerComponentMode,
ViewerComponentModeGroups and viewer_component_mode_value after L3 removed them,
so Sphinx -W failed. autodoc now derives the members from the module.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Windows portalocker locks are mandatory: startup_owner, record_startup_owner
and release_startup_owner opened the held lock file through a second handle
and failed with PermissionError (Errno 13). startup_lock now opens the file
read/write without append and registers the held handle; the owner record
helpers use it whenever this process holds the lock.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trissim trissim changed the title B6: startup owner through the held lock on Windows (0.6.1); docs members derived B6: startup owner through the held lock on Windows (0.6.2); docs members derived Oct 11, 2026
@trissim
trissim merged commit 4826549 into main Oct 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants