Repository navigation
0.6.4: ZMQServer is a plain ABC; private IPC endpoints under the socket root - #33
Merged
Merged
Conversation
ZMQServer kept a registry keyed by _server_type. Nothing reads it, and several server classes serve one role (every ExecutionServer subclass reports 'execution'), so under metaclass-registry 0.4.0, where a key names one class, the second subclass raised DuplicateRegistryKeyError. _server_type stays as the role reported in the pong. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…class-registry 0.4 IpcTransportDeclaration.private_endpoint created its directory with tempfile's default, so a long TMPDIR produced socket paths over zmq.IPC_PATH_MAX_LEN that no server could bind. The directory is now made beneath config.socket_root(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.6.4.
ZMQServerno longer keeps a registry keyed by_server_type. Nothing read it, and everyExecutionServersubclass reports'execution', so under metaclass-registry 0.4.0 (a key names one class) a second subclass in one process raisedDuplicateRegistryKeyError._server_typestays as the role reported in the pong. Removes the public, unreadZMQServer.__registry__.IpcTransportDeclaration.private_endpointcreates its directory beneathconfig.socket_root()instead ofTMPDIR, so the socket path length no longer depends onTMPDIR(a path overzmq.IPC_PATH_MAX_LENcannot be bound). Test:test_private_ipc_endpoint_lives_under_the_socket_root_not_tmpdir(fails before the change).metaclass-registry>=0.4.0.Local run, fresh venv, dependencies from PyPI (metaclass-registry 0.4.0), Python 3.12:
382 passed, 8 skipped.🤖 Generated with Claude Code