Repository navigation
K8: materialization owned by core; one value-to-JSON encoder; result file kinds as a family - #1208
Merged
Merged
Conversation
…ed on E1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…condary_objects Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ialization, all importers updated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e; ResultFileFormat family replaces the FileFormat enum; guards Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…module; receipt; browser test stub Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
marked this pull request as ready for review
October 11, 2026 20:58
…tch, boolean chains, redundant type checks) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K8 · PR #1208 · guards 3/3 · production −341 +300 · tests −155 +266
Receipt:
docs/refactor/consolidation-20261009/K8-contract-materialization.md(deletion certificates and the tests-only list are there).What changed
openhcs/processing/materialization/is nowopenhcs/core/materialization/. Every importer is updated; there is no re-export.json_payload_value,JsonPayloadAuthorityandbenchmark/validation/corpus.py::_json_valueare replaced bypython_introspect.to_jsonable.ColumnarRows,DataFrameandSeriesjoin by registration.FileFormat(Enum)is theResultFileFormatfamily (core/result_file_formats.py). Each kind owns its suffixes, its preview and how the browser opens it.RESULT_FILE_ACTIONS,ResultFileActionand the inventory's member lists are deleted, along with four unreferenced members.SecondaryObjectStatscomputation inidentify_secondary_objectsis deleted, with its class.0dd77da46; no production change.tests/unit/test_k8_materialization_guards.py. TwoFileFormatrows leave E1's enum-dispatch table.Owner decision (K8-Q1)
User custom functions that import
openhcs.processing.materializationfail on import until edited toopenhcs.core.materialization. Default: no tool, same as G7-Q1 and K4-Q1.Checks
origin/main(44980dfe2). The tenth (test_synthetic_plate_mcp_progress[False]) and the two errors (test_classification_two_vector_authoring) pass when run alone, here and on main.tests/pyqt_gui/test_image_browser_filter_controller.py: 8 passed (3 failed on main for a stale stub, fixed here).3c6ace299. Later commits change only the result-file preview reader and the image browser. An earlier run failed because the client reached another worktree's execution server.openhcs) and nra-r1 exit 1 because of the move: both key counts by file path, so the moved files' unchanged counts show as new under the new path and gone under the old one. No other key increased.scriptsandbenchmarkratchets exit 0.🤖 Generated with Claude Code