Repository navigation
B6b: fix E1's half-migrated export-scope and UI-action-status callers (run_datasets broken on main) - #1212
Merged
Conversation
…s; GUI smoke reads the action status class E1 (#1203) made the export scope and the UI action status class families but left three callers on the old shape: - the measured CLI passed the scope class into DatasetRunRequest, whose field is the name view (TypeError in validation); - RunDatasets passed the name member to Session.observation_export_params, which calls scope-class methods (AttributeError, every run rejected); - scripts/smoke_installed_gui.py read UiActionInvocationStatus.ACCEPTED. Tests: one per caller, parametrized over the registered family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
added a commit
that referenced
this pull request
Oct 12, 2026
The installed-GUI smoke keeps formbridge's bridge DTO paths and the datasets widget identity, and reads the action status as the UiActionInvocationStatus class family from formbridge.bridge.dto. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is broken since E1 (#1203): every
run_datasetscall is rejected, the measured CLI cannot build its run request, and the installed GUI smoke raises. This PR is only that fix and its tests.What fails on main (
a751b0eba, observed)E1 made the export scope and the UI action status class families and left three callers on the old shape:
RunDatasets.runpasses the request's name member toSession.observation_export_params, which calls scope-class methodsAttributeError: 'ZMQRuntimeObservationExportScope' object has no attribute 'check_export_path'; the operation returnsrejected(run_datasets_failed)openhcs-benchmark run-measuredpasses the scope class intoDatasetRunRequest, whose field is the name viewTypeError: DatasetRunRequest.runtime_observation_export_scope must be ZMQRuntimeObservationExportScope; got AutoRegisterMeta.scripts/smoke_installed_gui.pyreadsUiActionInvocationStatus.ACCEPTEDAttributeError: type object 'UiActionInvocationStatus' has no attribute 'ACCEPTED'On main,
tests/integration/test_agent_observation_export_zmq.py,test_session_journey.pyandtest_measured_cli_session.pygive 10 failed, 21 passed (withtests/unit/test_smoke_installed_gui.py); 8 of the 10 are these boundaries. The GUI journey waits out its 300 s stage timeout.Fix
RunDatasets.runhands the sessionrequest.runtime_observation_export_scope.scope(the class).RuntimeObservationExportScopeName(args.observation_scope).action_result.status is ActionAccepted, inrequire_ui_action_acceptedso a test can call it.Tests (fail on main, pass here)
tests/unit/test_run_request_export_scope.py: for every registered scope,RunDatasets.rungives the realSession.observation_export_paramsthe scope class.tests/unit/test_benchmark_control.py::test_measured_cli_builds_its_run_request_for_every_observation_scope.tests/unit/test_smoke_installed_gui.py::test_gui_smoke_accepts_only_an_accepted_ui_action, over the status family.Observed: on main's sources 5 failed plus a collection error for the smoke module; with the fix
64 passed. The three integration files with the fix:3 failed, 12 passed.Still failing after this PR (not this boundary; fixed in the B6b follow-up)
test_ordinary_execution_can_export_outcomes_without_value_observation:KeyError: 'well_count'(stale test).test_read_only_dataset_initializes_in_a_mirrored_workspace:PipelineOrchestratorhas noplate_path(stale test).test_stopped_run_is_cancelled_and_refuses_finalization: timing-dependent. A stop that lands during compile-before-execution ends asfailed, notcancelled. It passed alone (1 passed) and failed in the full file under load.B6b · guards 3/3 · guardrails rc=0 · production −12 +21 · tests −2 +158🤖 Generated with Claude Code