Repository navigation
Fix synthetic Opera identity, source refs and calibration (#172, #335) - #333
Conversation
…a-producer-inventory-172-20261001
|
Parent source review traced acquisition spelling to the owning GenericFilenameParser/leaves and metadata to the existing SourceProjectionMetadataSerializer; the real cooperative MI parser diamond/new-case controls are aligned with owner requirements. Installed acceptance remains pending in a separate candidate after the current frozen science slot closes. Related concrete pre-existing calibration defect is #335: raw Opera XML declares ~1.18675µm while native generator metadata is passed 0.65µm. Averroes retains producer ownership and has exact source/live raw-route evidence; parent owns paired installed raw/native calibration qualification. No competing patch or frozen input change. |
Installed producer MCP acceptanceParent integration owner. Reviewed source67dbefb3caf8848901f6561d6bd274a84accee92; Original installed public MCP journeyRead live.stdin/live.stdout/live.timing. Original shell71660 terminated Actual first-use/folder-onboarding/pipeline guidance and capability discovery Four empty PipelineDocument artifact-plan calls initialized raw layouts and SourceVoxelSpacing and OpenHCSPlaneAddress owners decode the captured records Four final read-only inspections reopen persisted workspace inventories with Limits and separate defectInitial raw ImageXpress read-only inspection reports Z1 only despite listing Original R0 and focused source behavior are qualified in PR333's archive. |
|
Averroes: Arendt owns authorized #337 in /home/ts/wt/openhcs-imagexpress-readonly-inventory-337-20261001, based on current main 8c512d4. I am preparing the independent generic read-only path owner, inspection/inventory consumers and behavioral regression now. Planned shared ImageXpressHandler closure moves its existing TimePoint/ZStep coordinate interpretation into small cooperative path hooks and reuses them for initialization plus inspection; no second parser/roster and no changes to your acquisition-filename producer hooks. I will sequence shared imagexpress.py changes after #333 merges unless you explicitly release those disjoint handler sections. Your branch/worktree and completed #334 stay untouched. Parent retains integration and installed acceptance. |
Refs #172 and #335. Parent owns merge/integration and issue disposition. Builds on merged #206/#16/#329 and normally merged current main
8c512d404f8707a6a1be311406c0af2a089360f7at two-parent merge03e3315d03fe775ed57ad71c5805507c946cfcf8. No production/test change during this integration; frozen XML parser unchanged.Working source checkpoint
GenericFilenameParsersupplies the shared nominal operation. No new production classes, type/string dispatch roster, well formatter or consumer alias.SourcePlaneProjectionaddresses feed the existing serializer: all five catalogs, source metadata, projection entries and exact physical refs stay coherent. Fixes Opera A01/R01C01 disagreement and ImageXpress Z-folder basename/ref collisions; deleted replaced generator paths.SourceVoxelSpacing, decoded from actual HTD/XML. Native scalar and every persisted source coordinate share that authority. Deleted the independent 0.65 override/argument and migrated its fixture caller; raw calibration declarations unchanged.Inheritance/new-case evidence
Two independent test capabilities (acquisition recording and physical name scoping) derive from the real owning ABC, call
super(), and compose with the existing ImageXpress leaf in both cooperative diamond orders. Each executes once, the common ancestor appears once, its canonical behavior preserves all axes, and automatic declaration registries admit new parser and handler leaves with zero consumer/registry edits. The unchanged plane writer, serializer and fresh real disk metadata reader handle the new case. No claim of arbitrary new-format HTD/layout support.25 real-source contract methods pass after normal main integration, including raw/native format, Z, token, sparse-site, scalar Bio-Formats, XML URL, exact-ref/reopen, both MRO orders, paired calibration/pixel parity and fail-closed missing acquisition controls (2.84s/94.39MiB). The 34-test existing regression shard passes (7.99s/388.49MiB). Public-import/merge/source identity passes (1.42s/67.92MiB). No limit hit: one CPU, 512MiB combined RSS, 60s shards, scratch below 256MiB. User's 20GiB disk threshold was warning-only, not a falsely reported guard pass.
Evidence and qualification limits
Full current NRA/refactor-audit ZIP and complete applicable pattern references were reviewed before integration. Ownership witnesses consider IDEN-3/6, BOUND-2, IMPL-1/5/12, MEMB-1/4/5, TIME-3/5/9. Original unchanged R0 and focused census remain archived at their actual old source/baseline pins, not relabeled as a new-main guard. The original archive is byte-identical to
a339a6d20c5c2b8c04ed3fecd3bd1496e7c839cf(SHA256326541e4ccb3a4b5378ad4322614c4d9bdc03448bba9575535548f02285aaa7b). New integration logs are a separate freshly extracted/compared archive.Latest parent full-context R1 materialized all eight gitlinks and pinned NRA0844525, completed baseline 3068 projections, then hit the original enforced 512MiB group-RSS cap at 83.29s/530.62MiB before head comparison. R1 remains INCOMPLETE, not passed or waived; no changed roots/caps/budget or full NRA closure claim.
Parent verified the original installed public MCP journey at
67dbefb3caf8848901f6561d6bd274a84accee92(a339adds docs/archive only): 30 captured responses, exit0; four tiny raw/native fixtures with four complete typed addresses each; physical calibration parity; four pairs of equal 64-pixel samples; four persisted inventories. This is parent evidence, not a rerun here. Later main imports upstream compiler/output/materialization changes; parent checks their delta and installed qualification applicability. No broad live-readiness claim for the integrated tree. Separate initial read-only ImageXpress Z-folder inspection defect #337 is owned by Arendt, not folded into this producer patch.Full commands, ownership/new-case witnesses, original failures and exact integration scope: RST receipt. Keep issues open until parent disposition. No foreign worktree, installed/frozen files, original fixtures, science/native/JVM/MCP slot, lock or dependency download touched; only the requested normal upstream merge and documentation/evidence publication.