Skip to content

Index captured subtree membership and fix style flags and stream stop - #128

Merged
trissim merged 10 commits into
mainfrom
fix/subtree-geometry-membership-20261008
Oct 8, 2026
Merged

trissim merged 10 commits into
mainfrom
fix/subtree-geometry-membership-20261008

Conversation

@trissim

@trissim trissim commented Oct 8, 2026 •

Copy link
Copy Markdown

Looking up a widget in a compositor subtree capture scanned every borrowed child; _compositor.py now builds an ordered lookup once per immutable capture and uses it for membership, captured parent and demand routing. The same change adds an overline field to Style, and widgets now build their visual style from the Rich style so all its flags carry over. MarkdownStream.stop now lets the task drain its pending text instead of cancelling it, and survives caller cancellation. Tests are added for each in test_viewport_geometry_targets.py, test_style_inheritance.py and test_markdown.py.

@trissim
trissim marked this pull request as ready for review October 8, 2026 18:57
Copilot AI balanced review requested due to automatic review settings October 8, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 94c5d95 into main Oct 8, 2026
0 of 22 checks passed
@trissim trissim changed the title Route retained geometry through its immutable source membership Index captured subtree membership and fix style flags and stream stop Oct 11, 2026
@trissim
trissim deleted the fix/subtree-geometry-membership-20261008 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants