Repository navigation
Yield to the event loop while building Markdown and composing widgets - #129
Merged
Merged
Conversation
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown built up to 200 root blocks in one go, and App and Widget compose collected all children without letting the event loop run.
compose.pynow hascompose_async, which shares one traversal withcomposebut sleeps for a loop turn between children, andapp.pyandwidget.pyuse it. Markdown construction in_markdown.pyyields between tokens and mounts each root before building the next, and the unused synchronous_build_from_sourceis removed. Tests are added totest_markdown.pyandtest_mount.py.