Repository navigation
Prepare immutable Markdown rows and sizes without mounting widgets - #130
Merged
Merged
Conversation
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing Markdown for display meant constructing, mounting, capturing and removing widgets on the UI thread. This change adds
document/_markdown.pyanddocument/_paint.py, which build rows and intrinsic sizes for an unchanging document from the same Markdown grammar and block classes without a widget tree. To support this it changes the compositor, box model, extrema, layouts, strip and visual code, adds a node-less path indom.py, and moves about 500 lines out ofwidget.py. The mounted widgets remain the path for interaction. Tests are added intest_markdown_document.pyand for stylesheet, layout factory, grid and geometry code.