Skip to content

Publish prepared wire text through the history window's reader position #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 8, 2026
Merged

Publish prepared wire text through the history window's reader position #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b6a20
Record delivered lazy notification contents and remaining pacing failure
trissim Oct 8, 2026
45c780a
Publish prepared wire bodies through their own reader mutation
trissim Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions evidence/dm-initial-publication-20261008/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,3 +791,26 @@ feedback rather than bypassing requests.
The initial evidence append was refused by the shell pre-execution parser on a
quotation in documentation; no command ran. The original tracked bytes were
materialized and this edit applied through the ordinary file patch tool.

## Deferred empty notification contents — delivered

Toad574 now creates the original native Contents only when the notification
body is acquired. Native title/toggle/focus/collapsed styling retain their
existing owners. General Collapsible child lifetimes are unchanged. The body
is retained across close/reopen and recomposed with its original notification.
Only compose/details change; all other methods are AST equal. Full288 production
and417 test modules parsed without omissions. Mouse/keyboard disclosure, live
error, collapsed update, reopen, recomposition and pre-mount acquisition passed
in the actual native App against source and the installed wheel.

The installed160-wheel/20-message/16-recipient burst recorded zero Contents
layout requests (previous40). Input stayed ordered. Wheel median4.25ms,
p95101.22/max145.45; final backlog10.32ms; framep95104.79/max152.90;
loopmax75.78. Frame pacing still fails the requested responsiveness. Native121
is also included; a single combined run does not isolate aggregate gains.

Installed for new launches through the original frontend publisher:
`.artifacts/dm-empty-disclosure-delivery-20261008/live-publication.json`.
Core/backend defaults, route and running owners are preserved. Existing windows
retain loaded modules. Raw checks/build/burst/publication:
`/home/ts/.cache/agent-scratch/dm-empty-disclosure-20261008/`.
10 changes: 7 additions & 3 deletions src/toad/widgets/irc_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,14 @@ async def preparation_publication(self, *, layout: bool):
async with super().preparation_publication(layout=layout):
yield
else:
# Worker completion changes this original row's measured extent.
# The mounted history already owns compensation and held readers.
async with history.native_publication(tuple(history.rows)):
# Prepared text changes this body's extent, not the page's row
# membership. Borrow the window's original reader without acquiring
# page trimming/selection protection or fencing unrelated rows.
window = history.window
anchor = window.reader_anchor(self)
async with window.preserve_history(anchor, root=self):
yield
window.check_follow()


class WireMarkdownMessage(CoreEventReceiver, ConversationBlock, VerticalGroup):
Expand Down
Loading