Skip to content

Limit DM and channel edge reads to the viewport's batch size #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 8, 2026
Merged

Limit DM and channel edge reads to the viewport's batch size #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93108be
Use viewport admission budget for wire history edge reads
trissim Oct 8, 2026
e630280
Merge remote-tracking branch 'origin/main' into fix/history-frame-wor…
trissim Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/toad/mounted_message_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,14 @@ async def _load_page(self, older: bool) -> None:
reader = self.reader
if reader is None or not self.rows:
return
limit = (min(HISTORY_PAGE_SIZE, HISTORY_WINDOW_SIZE - len(self.rows))
if older and self.window.follows_tail else HISTORY_PAGE_SIZE)
# This read is a native admission, not the transport's incremental
# scan. Its result mounts immediately. Use the window's existing
# admission budget so one edge read cannot arrange and start rendering
# an entire transport page before pointer input gets another frame.
limit = min(HISTORY_PAGE_SIZE,
self.window.document_viewport.budget.admission_items)
if older and self.window.follows_tail:
limit = min(limit, HISTORY_WINDOW_SIZE - len(self.rows))
if limit <= 0:
return
edge = self.rows[0 if older else -1][0].view_cursor
Expand Down
Loading