Repository navigation
Import UI modules lazily in the CLI; pass categories to preparation - #583
Merged
Merged
Conversation
Keep Click declarations and renderer-choice discovery available to console-entrypoint spawn imports. Move ToadApp into run/acp terminal branches and about, ApplicationLifetime into the three server branches, and annotation-only App/AgentDefinition/Renderer imports behind TYPE_CHECKING. No wrapper entrypoint or alternate pool. NRA AST traced all CLI declarations/callers and renderer imports across 862 Toad/Core/native production files with zero parse omissions. CLI declaration set, classes, AST signatures, returns and decorators are unchanged. Native help/version output is byte-identical; actual ACP project-option precedence and renderer choices pass. Actual existing RenderProcessPool spawn borrowed the unchanged installed console script as its original main path, delivered RichRenderTask through PreparationRuntime, and confirmed the worker imported toad.cli without toad.app, application_lifetime or conversation. Worker shutdown left no child. One worker, installed dependencies, no App/provider/build launch.
Keep Click declarations and renderer-choice discovery available to console-entrypoint spawn imports. Move ToadApp into run/acp terminal branches and about, ApplicationLifetime into the three server branches, and annotation-only App/AgentDefinition/Renderer imports behind TYPE_CHECKING. No wrapper entrypoint or alternate pool. NRA AST traced all CLI declarations/callers and renderer imports across 862 Toad/Core/native production files with zero parse omissions. CLI declaration set, classes, AST signatures, returns and decorators are unchanged. Native help/version output is byte-identical; actual ACP project-option precedence and renderer choices pass. Actual existing RenderProcessPool spawn borrowed the unchanged installed console script as its original main path, delivered RichRenderTask through PreparationRuntime, and confirmed the worker imported toad.cli without toad.app, application_lifetime or conversation. Worker shutdown left no child. One worker, installed dependencies, no App/provider/build launch.
Snapshot and checkpoint publication pass the actual view categories into unattached history preparation. TranscriptBodyPreparation skips filtered source fragments; TranscriptFragmentView retains their source slots without hidden native children and uses its existing body publisher on reveal. PreparedContentRange owns extension and replacement construction in four-part mount bursts with existing admission guards and rollback. TranscriptPageView acquires large destination slices through that owner. Preserve StreamingMarkdown prefix ordering in its extension call. Keep original four-fragment page-load admission after larger cohorts regressed. Source trace covered 862 Toad/Core/native modules with no AST parse omissions. Qualified the real 147MB saved source through the original observer journey: 320 native wheel packets, three reversals, no provider input or application error; max delivery 219.7ms versus retained baseline 393.5ms. Original canonical page read 0.105s. Real category hide/reveal preserved canonical page and collapsed unformatted disclosure identity. Qualification uses a source overlay on installed dependencies, not an installed delivery. Five-second agent-tab startup remains unresolved; original ACP attachment and metadata precede bounded snapshot publication. No viewport_body or native compositor changes.
…ory-model-20261008
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex work, mostly replaced. 21 of 80 code lines it added are still in main.
cli.pynow imports the app, application lifetime and renderer types only when a command needs them. Transcript categories are passed into fragment preparation, and prepared Markdown, the presentation window, streaming Markdown and transcript history are adjusted to use them.conversation.pyand the model picker pilot test are also changed.