Skip to content

[#165] Compile each runScriptOnConnector script once per engine and let evicted scripts unload #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maximthomas merged 8 commits into from
Oct 20, 2026
Merged

[#165] Compile each runScriptOnConnector script once per engine and let evicted scripts unload #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4b1286
[#165] Compile runScriptOnConnector scripts once per engine, in child…
maximthomas Oct 15, 2026
a40030c
[#165] Keep at most 64 runScriptOnConnector classes per engine and un…
maximthomas Oct 15, 2026
a872c5b
[#165] Run runScriptOnConnector scripts from the per-engine class cache
maximthomas Oct 15, 2026
ed25f73
[#165] Report a broken script-root class as a compilation failure, no…
maximthomas Oct 15, 2026
ce3a86f
[#165] Resolve script-root classes through the engine and compile eac…
maximthomas Oct 15, 2026
37b50d1
[#165] Run a cached text against the classes it was compiled against,…
maximthomas Oct 15, 2026
21f99b4
[#165] Compile runScriptOnConnector texts under the engine's compiler…
maximthomas Oct 20, 2026
7b06bd4
[#165] Compile the classes a runScriptOnConnector text parses at run …
maximthomas Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...or/src/main/groovy/org/forgerock/openicf/misc/scriptedcommon/ScriptedConnectorBase.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@
* with the fields enclosed by brackets [] replaced by
* your own identifying information:
* "Portions Copyrighted [year] [name of copyright owner]"
*
* Portions Copyrighted 2026 3A Systems, LLC
*/

package org.forgerock.openicf.misc.scriptedcommon

import org.codehaus.groovy.runtime.InvokerHelper
import org.identityconnectors.common.CollectionUtil
import org.identityconnectors.common.StringUtil
import org.identityconnectors.common.logging.Log
Expand Down Expand Up @@ -339,8 +340,6 @@ public class ScriptedConnectorBase<C extends ScriptedConfiguration> implements A
if (GROOVY.equalsIgnoreCase(request.getScriptLanguage())
&& StringUtil.isNotBlank(request.getScriptText())) {
try {
final GroovyCodeSource codeSource = new GroovyCodeSource(request.scriptText,
"Script" + System.currentTimeMillis() + ".groovy", "fix");
Binding binding = new Binding();
for (Map.Entry<String, Object> entry : request.scriptArguments) {
binding.setVariable(entry.key, entry.value)
Expand All @@ -349,10 +348,10 @@ public class ScriptedConnectorBase<C extends ScriptedConfiguration> implements A
createBinding(binding, OperationType.RUNSCRIPTONCONNECTOR, null, null, null, options),
{ String scriptName, Binding arguments ->
arguments.setVariable(LOGGER, logger)
return InvokerHelper.createScript(getScriptedConfiguration().getGroovyScriptEngine().
getGroovyClassLoader().parseClass(codeSource, false),
arguments).run();
});
// Compiled once per text and run from Java, see evaluateScriptOnConnector.
return getScriptedConfiguration().evaluateScriptOnConnector(request.scriptText,
arguments)
});
} catch (final RuntimeException e) {
throw e;
} catch (final Exception e) {
Expand Down
Loading
Loading