You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove the client's JavaFX dependency after #437 #471
#437 replaces the WebView-based tag field with Swing. That tag field was the only JavaFX user in the Administrator client: #277 (crash on JREs without JavaFX) came from its JFXPanel, and #278 added the startup check to give a clearer error. Once #437 merges, these JavaFX leftovers can go:
Platform.setImplicitExit(false) in Frame.java: only kept the JavaFX runtime alive between tag fields.
@ssrowe One more leftover for the list: the devClient task in client/build.gradle also passes -Dcom.sun.webkit.useHTTP2Loader=false. It only applied to the tag field's WebView, so it can go together with the javafx.* entries in --add-modules.
.sdkmanrc pins java=17.0.17.fx-zulu, and the Dockerfile builds with it. Switch it to a JDK without JavaFX in the same PR, so the build stops depending on it.
The server puts every jar in client-lib into the JNLP: on a build of Replace webview based tags control #437 the folder has 91 jars and the JNLP lists the same 91, openjfx.jar included. The installer removes the previous release's files, but anyone upgrading by unpacking the tar.gz or zip over an existing install keeps the old openjfx.jar, so the release notes need to say to delete client-lib/openjfx.jar.
Checked #437's head in the real Administrator: after opening the channel editor and both tag filters, no JavaFX threads are running. Its base runs four.
Activity
tonygermano commentedon Oct 24, 2026
@ssrowe One more leftover for the list: the
devClienttask inclient/build.gradlealso passes-Dcom.sun.webkit.useHTTP2Loader=false. It only applied to the tag field's WebView, so it can go together with thejavafx.*entries in--add-modules.pacmano1 commentedon Oct 25, 2026
Two more for the list:
.sdkmanrcpinsjava=17.0.17.fx-zulu, and the Dockerfile builds with it. Switch it to a JDK without JavaFX in the same PR, so the build stops depending on it.client-libinto the JNLP: on a build of Replace webview based tags control #437 the folder has 91 jars and the JNLP lists the same 91,openjfx.jarincluded. The installer removes the previous release's files, but anyone upgrading by unpacking the tar.gz or zip over an existing install keeps the oldopenjfx.jar, so the release notes need to say to deleteclient-lib/openjfx.jar.Checked #437's head in the real Administrator: after opening the channel editor and both tag filters, no JavaFX threads are running. Its base runs four.
tonygermano commentedon Oct 26, 2026
We do not support doing this, we would have the same issue for tons of libraries.