Repository navigation
Add checkbox option to start OIE service after install - #505
Open
paul-hristea wants to merge 2 commits into
Open
paul-hristea wants to merge 2 commits into
paul-hristea wants to merge 2 commits into
Conversation
Signed-off-by: Paul Hristea <paul.hristea@novamap.health>
pacmano1
marked this pull request as ready for review
October 20, 2026 20:44
pacmano1
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan,
pacmano1 and
ssrowe
October 20, 2026 20:44
pacmano1
requested changes
Oct 20, 2026
Contributor
Author
Currently the default is checked only for fresh installs, when it's an update it defaults to unchecked. Do you think it's best to default to unchecked in all cases? |
Contributor
|
I probably defaulted to unchecked. But I will defer to others. This practice would be to fix up user permissions anyway for the service user. |
Default Start Service checkbox to unchecked Update readme.html Signed-off-by: Paul Hristea <paul.hristea@novamap.health>
Contributor
Author
|
PR description updated to reflect changes. |
pacmano1
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #420, affects #169.
Suggestion for adding a checkbox option to start the OIE service after a successful install.
This is what it would look like:
A. Option Checked
If the option is checked, next we would see:
...and then if the service start was successful:
...otherwise if there was a startup error:
B. Option Unchecked
If the checkbox was left unselected, next the Finish page would simply read:
Notes:
startServiceNowvariable from response file, effectively enforcing manual selection every time-VstartServiceNow=trueAdditionally, customized styling for the readme.html installer screen to match install4j aesthetic: