Repository navigation
Conversation
Several tests would fail if run in a shared JVM depending on what tests ran before them. Traced to setting mocks without cleaning them up. As it happens, those were the only uses of Guice in the system. Removed. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
October 26, 2026 20:56
NicoPiel
previously approved these changes
Oct 27, 2026
NicoPiel
left a comment
NicoPiel
left a comment
Contributor
There was a problem hiding this comment.
Clean ups:
- Wrong copy-pasted comments. All four TODOs in DatabaseConnectionPoolTests say “leaks channelController”, but they are on the DonkeyConnectionPools, Donkey, ControllerFactory and SqlConfig overrides.
- Stale Guice references left behind:
- server/docs/thirdparty/THIRD-PARTY-README.txt:29 still lists “Guice 4.1”. The library no longer ships, so this line should go.
- gradle/vendored-layout.json still has com.google.inject:guice (lines 132 and 186). It doesn’t break the build, because the check only fails on missing entries, but it’s dead config now.
- gradle/verification-metadata.xml still has entries for guice, guice-parent and javax.inject:1. These are harmless but stale, and can be regenerated.
mgaffigan
force-pushed
the
feat/singleton-test-hooks
branch
from
October 27, 2026 15:51
2a38f6e to
5dce3cb
Compare
Contributor
Author
|
Oops. I was missing the push to remove the stale references. |
NicoPiel
approved these changes
Oct 28, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests would fail if run in a shared JVM depending on what tests ran before them. Traced to setting mocks without cleaning them up.
As it happens, those were the only uses of Guice in the system. Removed. Revised model matches the JavaScriptBuilder.setControllersForTesting precedent.
Found during #449