Skip to content

Fix authenticated sqli - #524

Open
mgaffigan wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:fix/sqli
Open

mgaffigan wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:fix/sqli

Conversation

@mgaffigan

Copy link
Copy Markdown
Contributor

Derby and MySQL allow EOP via SQLi at GET /events?name=<payload>. Authentication is still required, so this vulnerability specifically affects MySQL or Derby users that are using RBAC.

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@github-actions

Copy link
Copy Markdown

Test Results

130 files  ±0  130 suites  ±0   4m 2s ⏱️ + 1m 0s
789 tests ±0  789 ✅ ±0  0 💤 ±0  0 ❌ ±0 
915 runs  ±0  909 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit ddee97f. ± Comparison against base commit a403039.

@tonygermano tonygermano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): Gemini said you can do this in a database-agnostic way where the concatenation occurs before it hits the database engine.

<if test='name != null'>
    <bind name="namePattern" value="'%' + name + '%'" />
    AND LOWER(NAME) LIKE LOWER(#{namePattern})
</if>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants