Repository navigation
feat(drivers/onedrive|drivers/onedrive_app): support permanent deleti… - #3185
Open
Dainsleif233 wants to merge 1 commit into
Open
Dainsleif233 wants to merge 1 commit into
Dainsleif233 wants to merge 1 commit into
Conversation
…on (close OpenListTeam#3172) - Add a `remove_way` select with `trash` and `delete` to the Onedrive and OnedriveAPP drivers - Call the Graph `permanentDelete` action when `remove_way` is `delete`; `trash` and unset values keep moving items to the recycle bin - Resolve the drive and item ids the action requires from the listed object, falling back to a metadata lookup and the drive itself - Cover the recycle bin and permanent delete paths with tests in both drivers Co-authored-by: DeepSeek <148330874+deepseek-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on (close #3172)
remove_wayselect withtrashanddeleteto the Onedrive and OnedriveAPP driverspermanentDeleteaction whenremove_wayisdelete;trashand unset values keep moving items to the recycle binSummary / 摘要
Adds a
Remove way(remove_way) select to the OneDrive and OneDrive APP drivers:Trash— default, and what an unset value means: plain Graph delete, the item goes to the OneDrive recycle bin.Delete— posts to the GraphpermanentDeleteaction: neither recycle bin stage is used and the space is released immediately.permanentDeleteis item-id scoped, so the item id comes from the listed object (falling back to a metadata lookup) and the drive id from itsparentReference(falling back to the drive itself). Existing storages keep the old behavior. Same option as the Aliyun Drive Open driver; no new Graph permission is needed./ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
src/lang/en/drivers.jsonis regenerated from this repository by the frontend'sSync i18n filesworkflow (chore: auto update i18n file).Related Issues / 关联 Issue
Closes #3172
Testing / 测试
go test ./drivers/onedrive/ ./drivers/onedrive_app/ -count=1— 6 tests each: unset/trash→ plain DELETE,delete→permanentDelete, ids resolved from the path, Graph errors propagated.go build ./...,go vet,gofmt— clean.go test ./...— run; the two changed packages pass, every other failure reproduces identically on unmodifiedmain(482464c) (e.g.lanzou/offline_download/115*fail to build under Go 1.27).Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution (Co-authored-by: DeepSeek <148330874+deepseek-ai@users.noreply.github.com>)./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。