Skip to content
This repository was archived by the owner on Sep 30, 2026. It is now read-only.

CI: give the Linux arm64 release archive its own name - #189

Merged
timosachsenberg merged 1 commit into
masterfrom
claude/name-fix-0qx0zj
Sep 28, 2026
Merged

timosachsenberg merged 1 commit into
masterfrom
claude/name-fix-0qx0zj

Conversation

@timosachsenberg

@timosachsenberg timosachsenberg commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Both Linux jobs (ubuntu-latest and ubuntu-24.04-arm) have runner.os == 'Linux', so both packaged and uploaded contrib_build-Linux.tar.gz to the same release. The job that finished last replaced the other job's archive. Releases 2026-09-28-154454 and 2026-03-25-183345 contain the x64 archive and no arm64 archive.

Set the archive name per matrix entry in ARCHIVE_NAME. The arm64 archive is now contrib_build-Linux-arm64.tar.gz. The x64 Linux, macOS and Windows names do not change, because the pyOpenMS wheel workflow and the app repositories download them by name.

Fixes #188

Claude-Session: https://claude.ai/code/session_01DBtFimdkibC67HrHN3hQwo

Summary by CodeRabbit

  • Bug Fixes
    • Release archives now have distinct names for Linux x64 and Linux ARM64 builds, making the platform-specific downloads easier to identify.

Both Linux jobs (ubuntu-latest and ubuntu-24.04-arm) have
runner.os == 'Linux', so both packaged and uploaded
contrib_build-Linux.tar.gz to the same release. The job that finished
last replaced the other job's archive. Releases 2026-09-28-154454 and
2026-03-25-183345 contain the x64 archive and no arm64 archive.

Set the archive name per matrix entry in ARCHIVE_NAME. The arm64
archive is now contrib_build-Linux-arm64.tar.gz. The x64 Linux, macOS
and Windows names do not change, because the pyOpenMS wheel workflow
and the app repositories download them by name.

Fixes #188

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DBtFimdkibC67HrHN3hQwo
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 84c3f4f4-80d2-4af5-861e-3e480107bf16

📥 Commits

Reviewing files that changed from the base of the PR and between d077390 and 6742688.

📒 Files selected for processing (1)
  • .github/workflows/main.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow matrix now assigns an explicit archive filename to each platform. Packaging and the Windows, macOS, and Linux release steps use that filename. Linux x64 and arm64 therefore map to distinct archive names.

Changes

Release archive naming

Layer / File(s) Summary
Assign and use platform archive names
.github/workflows/main.yml
The build matrix assigns each platform an archive name. Packaging and release steps use that value to name and select the archive. Linux x64 and arm64 receive distinct names.

Priority: ➖ Normal

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 67426

The workflow keeps the existing x64 Linux, macOS, and Windows archive names while giving Linux arm64 a separate asset. No release-archive risk remains that warrants delaying merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 67426

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/main.yml: The matrix adds per-OS archive names, including a distinct Linux arm64 name; Ubuntu x64, macOS, and Windows retain their respective platform names. The existing OS-specific CMake arguments and versions remain unchanged.
  • observed — Modified behavior in .github/workflows/main.yml: Packaging now names the tarball with matrix.ARCHIVE_NAME instead of runner.os, so the Linux x64 and arm64 jobs produce differently named archives.
  • observed — Modified behavior in .github/workflows/main.yml: The Windows release step now selects the packaged file using matrix.ARCHIVE_NAME instead of a filename derived from runner.os.
  • observed — Modified behavior in .github/workflows/main.yml: The Mac and Linux release step now selects the packaged file using matrix.ARCHIVE_NAME instead of a filename derived from runner.os.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: giving the Linux arm64 release archive its own name.
Linked Issues check ✅ Passed Issue #188 requires a distinct archive name for Linux arm64 and unchanged names for Linux x64, macOS, and Windows. The workflow assigns contrib_build-Linux-arm64.tar.gz to arm64 and preserves the th…
Out of Scope Changes check ✅ Passed All changes in .github/workflows/main.yml support issue #188 by selecting and uploading the per-matrix archive name. The issue excludes release publication timing and Windows asset availability from…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit packs the Linux pair,
With names that show which builds are there.
Mac and Windows keep their own,
Each archive has a name alone.
The release shelf now holds them clear.

Comment @coderabbitai help to get the list of available commands.

@timosachsenberg
timosachsenberg merged commit 42847d4 into master Sep 28, 2026
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release: Linux x64 and arm64 jobs upload the same asset name and overwrite each other

2 participants