Skip to content

fix(web): remove the saved-list button that did nothing - #1016

Merged
Medformatik merged 1 commit into
fix/stop-board-arrivals-togglefrom
fix/saved-list-dead-add-place-button
Nov 16, 2026
Merged

Medformatik merged 1 commit into
fix/stop-board-arrivals-togglefrom
fix/saved-list-dead-add-place-button

Conversation

@Medformatik

Copy link
Copy Markdown
Collaborator

What changed and why

The header of a saved list showed two buttons, Share and "Add place". "Add place" had no click handler and did nothing. It was added that way in March and never wired.

There is nothing to wire it to: no part of the web, core or mobile code can add a place to a given list from the list itself. Places are added from a place's own Save dialog, and a list's menu already offers importing into it. Building a picker would be a new feature, which the freeze rules out, so the button and its unused translation string are removed.

Verification

  • New case in SavedListDetail.test.tsx: the header offers Share and no "Add place"; it failed before the change.
  • The string saved.addPlace had no other use anywhere in the repository. pnpm check-translations, the web typecheck and Biome on the touched files pass locally.
  • Not verified: in a browser, so there is no before/after screenshot of the list header. The change is one button fewer next to Share.

Release and upgrade impact

Product impact: ordinary

No package release: the extension CLI bundles some core sources but none of the code changed in this stack; its built bundle contains no trace of it.

@Medformatik Medformatik self-assigned this Nov 16, 2026
@Medformatik
Medformatik added this pull request to stack #989 November 16, 2026 10:05
@Medformatik
Medformatik merged commit 79eb353 into main Nov 16, 2026
25 checks passed
@Medformatik
Medformatik deleted the fix/saved-list-dead-add-place-button branch November 16, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant