Repository navigation
fix(web): remove the saved-list button that did nothing - #1016
Merged
Medformatik merged 1 commit intoNov 16, 2026
Merged
Medformatik merged 1 commit into
Medformatik merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The header of a saved list showed two buttons, Share and "Add place". "Add place" had no click handler and did nothing. It was added that way in March and never wired.
There is nothing to wire it to: no part of the web, core or mobile code can add a place to a given list from the list itself. Places are added from a place's own Save dialog, and a list's menu already offers importing into it. Building a picker would be a new feature, which the freeze rules out, so the button and its unused translation string are removed.
Verification
SavedListDetail.test.tsx: the header offers Share and no "Add place"; it failed before the change.saved.addPlacehad no other use anywhere in the repository.pnpm check-translations, the web typecheck and Biome on the touched files pass locally.Release and upgrade impact
Product impact: ordinary
No package release: the extension CLI bundles some core sources but none of the code changed in this stack; its built bundle contains no trace of it.