Repository navigation
fix(services): give Nominatim its own database password - #987
Open
Medformatik wants to merge 1 commit into
Open
Medformatik wants to merge 1 commit into
Medformatik wants to merge 1 commit into
Conversation
Medformatik
force-pushed
the
fix/nominatim-own-database-password
branch
from
November 16, 2026 10:00
a1ab60e to
6cc543e
Compare
The Nominatim container received the PostgreSQL superuser's password as the password of its bundled database. It now reads NOMINATIM_DB_PASSWORD, the CLI rejects a weak value or a copy of the superuser's, and the host-authority check reports any service other than PostGIS that references it.
Medformatik
force-pushed
the
fix/nominatim-own-database-password
branch
from
November 16, 2026 17:23
6cc543e to
42b057f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The built-in Nominatim service set the password of its own bundled database from
POSTGRES_PASSWORD, so a third-party geocoder container held the credential that owns the platform database. The configuration guide already said only PostGIS administration and the CLI's backups use that password.Nominatim now reads its own
NOMINATIM_DB_PASSWORD, in the same way Martin readsMARTIN_DB_PASSWORD, and does not render without it. The CLI rejects a value that is too short, a known placeholder or equal toPOSTGRES_PASSWORD. The host-authority check now reports any service other than PostGIS whose manifest references the superuser's password, so this cannot come back unnoticed.Related work
Third layer of the stack that starts with #983.
Verification
pnpm check-ops-authoritypasses on the tree;check-typesforpackages/cli, Biome and Prettier pass on the touched files.Release and upgrade impact
Product impact: security, operator-action
Deployments that enabled Nominatim must set
NOMINATIM_DB_PASSWORDininfra/docker/.envbefore the next render, and should rotatePOSTGRES_PASSWORD. The release-notes fragment has the steps.No package release: the extension CLI is counted through shared core sources, but the only core change widens an error's issue type used by the deployment CLI.