Repository navigation
fix(api): keep server-side fetches on the hosts they are meant for - #999
Open
Medformatik wants to merge 1 commit into
Open
Medformatik wants to merge 1 commit into
Medformatik wants to merge 1 commit into
Conversation
Medformatik
force-pushed
the
fix/outbound-url-trust
branch
from
November 16, 2026 10:00
2810941 to
e56daf0
Compare
The CityBikes client built a request URL by appending a link from the upstream index to its base, so the link could name another host; it now accepts only a network path on the CityBikes origin. The private feed host setting applied to every safe fetch by default, including the extension store; feed downloads now opt in and everything else refuses private hosts.
Medformatik
force-pushed
the
fix/outbound-url-trust
branch
from
November 16, 2026 17:23
e56daf0 to
4db59ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Two server-side fetches could reach hosts they were not meant for.
The CityBikes client appended a link taken from the upstream network index to its base URL as text. A link that did not start with a single slash would have named a different host. The client now resolves the link against the base and uses it only when it is a network path on the CityBikes origin; other entries are dropped before the index is cached and skipped again before each fetch.
OPENMAPX_ALLOW_PRIVATE_FEED_HOSTSlets an operator reach transit and mobility feed mirrors on a private network. The safe fetch helpers applied it by default to every caller that did not say otherwise, which included the extension store's catalog, manifest and revocation requests. The default is now no private hosts. The mobility transport and the GOFS fetchers pass the feed list themselves, and the extension store states the refusal explicitly. The variable is now documented in the configuration reference.A sweep of the integrations for the same URL pattern found no other instance. Noted for later and not changed here: the bike-sharing clients call the shared fetch helper instead of the integration HTTP client.
Related work
Sixth layer of the stack that starts with #983. It covers two audit findings in one change because both are a few lines in the same area.
Verification
check-typespasses forpackages/coreandapps/api(which covers the integrations); Biome, Prettier,check-declared-imports,check-integration-cache-writesandcheck-unused-exportspass.Release and upgrade impact
No operator action and no migration. Feed mirrors on allowlisted private hosts keep working.
No package release: the extension CLI is counted through shared core sources; the changed default only affects server-side fetch helpers the CLI does not call with private hosts.