Skip to content

fix loadFile for package.mo: don't copy it out of its package directory - #476

Merged
arun3688 merged 12 commits into
OpenModelica:masterfrom
arun3688:loadfile
Oct 2, 2026
Merged

arun3688 merged 12 commits into
OpenModelica:masterfrom
arun3688:loadfile

Conversation

@arun3688

Copy link
Copy Markdown
Collaborator

Related Issues

OpenModelica/OpenModelica#16771

Purpose

load directory-based packages (package.mo) in place instead of copying just the one file, it is possible the model might be located in sub-directories

@adeas31

adeas31 commented Sep 22, 2026

Copy link
Copy Markdown
Member

@arun3688 would be nice to add a test about it so we don't break it in future.

@arun3688

Copy link
Copy Markdown
Collaborator Author

@adeas31 sure i will add it

@AnHeuermann

Copy link
Copy Markdown
Member

I updated the Windows installer, let's see if the Windows nightly test passes now.

@adeas31

adeas31 commented Sep 23, 2026

Copy link
Copy Markdown
Member

I think the Windows tests will still fail. See #478

@adeas31

adeas31 commented Sep 30, 2026

Copy link
Copy Markdown
Member

Don't skip the linerarization tests. If we have changed the output then update the test.

@arun3688

arun3688 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

this should be fixed with this OpenModelica/OpenModelica#17046, test it from tomorrow nightly builds

@casella

casella commented Oct 1, 2026

Copy link
Copy Markdown

@arun3688, didn't make it through the testsuite.

@arun3688

arun3688 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@casella yes the problem is on the nightly builds, since the default runtime has been changed to rust, i implemented the fix today OpenModelica/OpenModelica#17046, so we have to wait for nightly builds tomorrow to get the fix for CI to pass

Comment thread tests/resources/BouncingBalls/Tests/package.mo Outdated
Comment thread tests/test_ModelicaSystemOMC.py Outdated
@arun3688
arun3688 merged commit 025daae into OpenModelica:master Oct 2, 2026
10 checks passed
@arun3688
arun3688 deleted the loadfile branch October 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants