Repository navigation
AWB import: route branch points through junction nodes - #339
Merged
Merged
Conversation
AWB draws parallel paths with no node: several connections leave a block or the start, several arrive at a block or the end. The import copied them as they were, but RAPTOR splits and joins only at a node, so the GUI flagged every such model and the engine's answer was wrong: OilAndGasExample came out 99.989 % available although block 1.5, at 8760 / (8760 + 240) = 97.33 %, is on every path. Each such point now gets an ordinary 1-of-n node, the meaning of a plain AWB junction (any one path through); the same model gives 97.34 %. Example1, MaximoDemo and SapDemo also lose their link warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338.
AWB lets several connections leave a block or the start, and several arrive at a block or the end, with no node. RAPTOR only splits and joins at a node. The import now inserts an ordinary node with k = 1 at each such point. That keeps the meaning of a plain AWB junction: any one path through.
Why it matters. This is not only about the warnings. The engine computes the wrong answer for the model as it was imported:
Block 1.5 is on every path and has an availability of 8760 / (8760 + 240) = 97.33 %. The system cannot be more available than that, so the 'before' figure is impossible.
AWB's own results for this example are not in the file: its availability profile is 1.0 throughout. The check is therefore this bound, not a comparison with AWB. Reading the plain AWB junction as 1-of-n is my interpretation. Every block in the example has
LogicMode0, the default, and no node in the file has a vote count.AWB examples (link and connection warnings, before and after):
ALTExample has no RBD diagram in the file, so it is unchanged.
Tests.
test_awb_branches_without_nodes_get_junction_nodesbuilds two blocks in parallel with no node, the way AWB draws them. It fails without the fix and passes with it.