Skip to content

reject csr with bad signature in cupsSignCredentialsRequest #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelrsweet merged 1 commit into from
Oct 5, 2026
Merged

reject csr with bad signature in cupsSignCredentialsRequest #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ v3.0.4 - YYYY-MM-DD
- Fixed a potential buffer overflow in `cupsDNSSDAssembleFullName` on Windows
(Issue #170)
- Fixed a potential string overrun when loading .strings files (Issue #171)
- Fixed `cupsSignCredentialsRequest` to reject requests with a bad signature
when using OpenSSL.
- Fixed an issue with `cupsGetCredentialsTrust` for credentials that are signed
by an unknown CA.
- Fixed PAM support in `ippeveprinter`.
Expand Down
2 changes: 1 addition & 1 deletion cups/tls-openssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ cupsSignCredentialsRequest(
return (false);
}

if (X509_REQ_verify(crq, X509_REQ_get_pubkey(crq)) < 0)
if (X509_REQ_verify(crq, X509_REQ_get_pubkey(crq)) <= 0)
{
_cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("Unable to verify X.509 certificate request."), true);
goto done;
Expand Down
Loading