Skip to content

fix: improve theme toggle visibility in light mode #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarshanKudrigi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: improve theme toggle visibility in light mode #317

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df3c51e
fix: improve theme toggle visibility in light mode
DarshanKudrigi Oct 14, 2026
56c472e
fix: improve theme toggle visibility in light mode
DarshanKudrigi Oct 14, 2026
3766600
fix: improve theme toggle visibility Final in light mode
DarshanKudrigi Oct 14, 2026
ea0a5b5
fix: visibility improved and also Fixed the error
DarshanKudrigi Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions theme/css/footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,21 @@ footer.footer{
height:24px;
appearance:none;
-webkit-appearance:none;
background:rgba(255,255,255,.12);
border:1px solid rgba(255,255,255,.18);
background:#fff;
border:2px solid #000;
border-radius:999px;
position:relative;
cursor:pointer;
outline:none;
display:inline-block;
box-sizing:border-box;
transition:border-color .22s ease, background .22s ease;
}

/* Accessible focus state */
.color_choice:focus-visible{
outline:2px solid var(--brand-strong);
outline-offset:3px;
}

/* The “knob” */
Expand All @@ -44,32 +52,32 @@ footer.footer{
position:absolute;
top:2px;
left:2px;
width:20px;
height:20px;
width:16px;
height:16px;
border-radius:50%;
background:#fff;
box-shadow:0 2px 8px rgba(0,0,0,.25);
background:#000;
transform:translateX(0);
transition:transform .22s ease, background .22s ease;
}

/* Dark mode: move knob right */
/* Dark mode: track and knob */
html[data-mode="dim"] .color_choice{
background:transparent;
border-color:#fff;
}

html[data-mode="dim"] .color_choice::after{
background:#fff;
transform:translateX(24px);
}

/* Optional: show a subtle sun/moon via emojis (no images needed) */
.color_choice:before{
content:"☀️";
position:absolute;
left:8px;
top:50%;
transform:translateY(-50%);
font-size:11px;
opacity:.8;
}
html[data-mode="dim"] .color_choice:before{
content:"🌙";
left:auto;
right:6px;
@media (prefers-color-scheme: dark){
html:not([data-mode="lit"]) .color_choice{
background:transparent;
border-color:#fff;
}
html:not([data-mode="lit"]) .color_choice::after{
background:#fff;
transform:translateX(24px);
}
}
Loading