Repository navigation
Conversation
Clip JSON can now load a pathless QtTextReader. The reader supports document layout, padding, stroke, border and per-clip style curves. For SCALE_NONE clips it rasterizes at the preview-to-project ratio, as QtImageReader does, so text keeps its project size in a resized preview instead of being drawn at full project pixels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Read fps from JSON instead of assuming 30 fps, so animated text style curves line up with project frames at 24/60 fps. - Populate reader info without rendering; constructors no longer draw a throwaway image. - Cache the last few animated style renders (bounded by count and bytes), so out-of-order frame requests do not re-render. - Re-render on background color changes only while open. - Tests for fps-correct animation, info without rendering, and cache reuse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Qt's offscreen platform only reads fonts from <Qt>/lib/fonts on Windows, which Qt no longer ships, so text rendered no pixels. Point QT_QPA_FONTDIR at the Windows fonts folder unless it is already set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1131 +/- ##
===========================================
+ Coverage 74.01% 74.64% +0.62%
===========================================
Files 275 276 +1
Lines 37119 37636 +517
===========================================
+ Hits 27475 28094 +619
+ Misses 9644 9542 -102 ☔ View full report in Codecov by Harness. |
The unreleased style keys now use Caption's names where they mean the same thing: stroke_color becomes stroke and padding becomes background_padding. border_color becomes border, so the four colors read color, background, stroke and border. Released QtTextReader keys are unchanged.
- background_corner rounds the text background, and the border follows the same curve. It animates per clip like the colors (text_animation), and is limited to half the box. - line_spacing sets the line height as a multiple of normal (1 = normal). It changes the box height, so it is a single value per text. - Both use the Caption effect's names, and default to the previous look. - The text outline is drawn in its own pass behind the letters, as in Caption, so a wide outline grows outward instead of covering them. The fill is drawn as a path too, so the first frame renders like the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the existing
QtTextReaderfor openshot-qt's new quick-text workflow (easy-text): OpenShot/openshot-qt#6215Clipcan now load aQtTextReaderfrom JSON