Repository navigation
Update boilerplate, add Python 3.15, adopt the dead-code hook - #90
Open
hmgaudecker wants to merge 4 commits into
Open
hmgaudecker wants to merge 4 commits into
hmgaudecker wants to merge 4 commits into
Conversation
- Python 3.15: py315 environment, CI matrix entry, classifier, requires-python bound, max_supported_python; pixi.lock regenerated (lock format v7). - ty runs as the ty-pre-commit hook against the py314 pixi env; the type-checking environment and ty task are gone. - Hook and action versions refreshed; template hooks added (codespell, pixi-lock-check, pre-push-hooks-installed, notebook-cell-source-format, no-hardcoded-user-paths, no-section-separator-comments, no-internal-references). - CLAUDE.md and GEMINI.md removed; AGENTS.md is the only instruction file. - .ai-instructions bumped, and excluded from ty. - Fixes the new hook versions demanded: a doubly unpacked TypeVarTuple in output.py, renamed ty rules, RUF036 union order, a README typo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds the vulture-based dead-code hook from .ai-instructions, its [tool.dead-code] table (src/dags/ as public API), its ci.skip entry and a run-ty CI step with the submodule checked out. Its first run reported _is_python_identifier in tree_utils.py as used only by tests. Nothing in dags or the gettsim workspace calls it, so it goes, with its regex constant and its test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This was referenced Nov 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 96.56% 96.54% -0.02%
==========================================
Files 27 27
Lines 1398 1391 -7
==========================================
- Hits 1350 1343 -7
Misses 48 48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The lock held prek 0.3.4, whose bundled uv 0.10.2 cannot parse ty-pre-commit's pyproject.toml (dependency tables with hashes), so the run-ty job failed while installing the hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The build fetches the newest MyST book theme, which no longer supports mystmd 1.8.2; the old engine reports the mismatch and then hangs, so Read the Docs kills the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Boilerplate, Python 3.15, ty as a hook (first commit)
py315pixi environment, CI matrix entry, classifier,requires-pythonupper bound,max_supported_python.pixi.lockregenerated (lock format v7).ty-pre-commithook (ty==0.0.104) against thepy314pixi environment. Thetype-checkingenvironment andtytask are removed; CI'srun-tyjob runsprek run ty.pixi run --lockedin CI.CLAUDE.mdandGEMINI.mdremoved;AGENTS.mdis the only instruction file.tuple[T, *Unpack[...]]unpacked a TypeVarTuple twice; it's now*MixedTupleType.Dead-code hook (second commit)
dead-codehook from.ai-instructions, with[tool.dead-code] public = ["src/dags/"], aci.skipentry, and arun-tystep with the submodule checked out..ai-instructionsis excluded from ty, since the hook script imports vulture from its own environment._is_python_identifierintree/tree_utils.pyas used only by tests. Nothing in dags or the gettsim workspace calls it, so it is removed along with its test.Supersedes #84, #87 and #89.
Checks
prek run --all-files: exit 0.