Skip to content

Maintain update - #8

Merged
Michal-Pogorzelec merged 19 commits into
mainfrom
dev/maintaining-update
Oct 4, 2026
Merged

Michal-Pogorzelec merged 19 commits into
mainfrom
dev/maintaining-update

Conversation

@Michal-Pogorzelec

Copy link
Copy Markdown
Member

No description provided.

@Michal-Pogorzelec
Michal-Pogorzelec requested a balanced review from Copilot October 4, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved build cleanup, ABI compatibility, and maximum packet-length issues remain.

Review effort: Lite
Findings: 2 Medium severity

Open (2)

Comment thread Makefile Outdated
Comment thread src/space_packet.c Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The maximum-length portability issue and cleanup failure path remain unresolved.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (2)
Previously missed (1)

In code that hasn't changed since last review

Low severity Configure clang-format to parse sources as C

.clang-format:2

This repository is built as strict C99 (Makefile:7-10), but Language: Cpp makes clang-format parse the .c sources as C++. That can reject or reformat C99-only constructs and leaves the formatter configuration inconsistent with the project; keep this setting as C.

Comment thread src/space_packet.c Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Unresolved formatter-language and build instrumentation issues could invalidate formatting and coverage/sanitizer checks.

Review effort: Lite
Findings: None

Resolved since last review (1)

@Michal-Pogorzelec Michal-Pogorzelec self-assigned this Oct 4, 2026
@Michal-Pogorzelec
Michal-Pogorzelec merged commit 231eb26 into main Oct 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants