Repository navigation
Fix partial attribute comparisons in 0.6 - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial attribute comparisons can use an offset from the start of the layout after their value pointers already include the requested offset. This can copy a nontrivial enum from the wrong address and crash in
swift_retain, or compare bytes outside the requested field.Apply the fix to
release/0.6: return the layout offset relative to the requested range and clamp it to the range size. Add four regression tests for enum payloads and case changes, custom equality, and field boundaries.Upstream PR: jcmosc#79
Related issue: jcmosc#78
Validation
release/0.6.