Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated subgraph updates can release child subgraphs too early when the traversal stack grows beyond its 32 inline entries. After the vector moves entries to heap storage, automatic destruction of the inline array releases the stale pointer copies again.
Use union-backed inline storage so the vector alone controls element construction and destruction. Add a regression test that keeps 64 child subgraphs alive across three invalidation and update cycles and checks their values.
The regression test crashes without the fix and passes with it. The SubgraphUpdateTests suite also passes on this branch.
Fixes OpenSwiftUIProject/Game2048#2.