Repository navigation
fix(appkit): map synthetic drags with the current window frame - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragged mouse events carry deltas, so
mouseMove(to:)sets them on the event'sCGEventand rebuilds the event withNSEvent(cgEvent:). That initializer maps the global location back with the window server's geometry instead ofNSWindow.frame, and AppKit updates that geometry asynchronously. The first drag after a window was created or moved could land far outside the window, for example at (-200, -1964) instead of (100, 100), so drag gestures started before reaching their minimum distance.Keep
HammerWindowat a fixed off-screen position while it is hidden, as WebKitTestRunner does for its test window: origin changes are ignored and only size changes apply. On macOS,isWindowReadyalso requires a probe event to round-trip throughNSEvent(cgEvent:)unchanged, sowaitUntilWindowIsReady()waits until a new window maps locations correctly. Dragged events keep their deltas.Validation: all 18 AppKit tests pass on macOS 26.6.2, and strict SwiftLint passes. SwiftUI and OpenSwiftUI drag gesture integration tests, including a minimum-distance case that failed before, pass on macOS 26.6.2.