Skip to content

Set the eval-test federation rule id - #30

Merged
irvingpop merged 1 commit into
mainfrom
eval-test-rule-id
Nov 6, 2026
Merged

irvingpop merged 1 commit into
mainfrom
eval-test-rule-id

Conversation

@irvingpop

Copy link
Copy Markdown
Member

Summary

  • evals.py: the eval-test entry of EVAL_FEDERATION now holds the rule the owner created on 2026-11-06 (eval-test-federation-rule, a copy of the eval rule with claim environment: eval-test). Branch evals no longer fail closed on "eval-test federation rule not configured".
  • Tests: the unset-rule fail-closed path stays covered with a monkeypatched entry.
  • Docs: the open owner step is replaced with the rule as created. The eval-test environment (required reviewer, prevent self-review) exists since 2026-11-06.

Review

Task review: 0 Critical, 0 Important. Unit tests 3016 passed. Signed commit.

After merge

V27 live check: an approved branch run on eval-test gets a token; other environments get none. This calls the live API (owner go first).

🤖 Generated with Claude Code

Rule eval-test-federation-rule (created 2026-11-06) is set in evals.py.
The unset path stays covered by a test that unsets the entry. Design doc
and build plan record the rule as created.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@irvingpop
irvingpop requested a review from a team as a code owner November 6, 2026 02:02
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

🔴 Comms down: the Claude of Duty review did not complete

Mission: Review the code. Protect the branch. Deploy the future.

Caution

The Review, Security and Supply chain reviews did not run, so this PR could not be judged. No waiver can clear this.
Next step: a maintainer re-runs the newest run of the required workflow once the cause is fixed. The author does not need to change anything.

Severity Effect Where Finding Found by
⚠️ Not run Blocks, no waiver Review, Security and Supply chain passes authentication failed. The pass returned no result. Workflow (code, no model)
File checks Review Security Supply chain Dependency review Coverage
✅ ok, 1 signal ❌ failed ❌ failed ❌ failed ✅ ok ✅ complete

Run 42147754667, attempt 1 for head 5e8af1f into main. The required workflow in the merge box is the result that counts.

Claude of Duty never approves a PR. A human reviewer gives the final approval.

📋 Full review record: reasons, checks, signals, finding details, model summaries, token usage

Reviewed snapshot

Head SHA Merge base SHA Base branch Run
5e8af1fcc8482ad9799b375d304e67565fa41a84 8992adbace81b1b45907152a0ebc87b210c36787 main 42147754667, attempt 1

Reasons the gate failed

Reason Waivable? Detail
A review pass failed 🚫 no pass review failed: authentication failed, pass security failed: authentication failed, pass supply-chain failed: authentication failed

No waiver line is shown. At least one reason cannot be waived, so a waiver would not change the result.

Checks (code, no model)

Check Result Detail
Hard blocks ✅ none
Coverage ✅ complete files in comparison 4, files collected 4, trees complete
Dependency changes ✅ none
Dependency review job ✅ success

Signals (context only, never block)

  • ℹ️ Very long line: lines longer than 500 characters, in docs/claude-review-design.md, lines 693 878 1086

Dependency changes

None.

Finding details

Model output from untrusted input. Check it before you act on it. Verified means only that the quoted text is at that place. It does not mean the claim is true.

Blocking is decided by code from category and severity, never by the model. A finding in a blocking category blocks only at high or critical severity.

No findings from the passes that ran. The Review, Security, Supply chain pass did not run, so this is not a clean result.

Model summaries

Model output from untrusted input. Check it before you act on it. Verified means only that the quoted text is at that place. It does not mean the claim is true.

Pass Status Model Summary
Review ❌ failed No summary. Reason: authentication failed
Security ❌ failed No summary. Reason: authentication failed
Supply chain ❌ failed No summary. Reason: authentication failed

Token usage

No token usage was recorded for any pass.

@irvingpop
irvingpop merged commit 08aa872 into main Nov 6, 2026
4 of 5 checks passed
@irvingpop
irvingpop deleted the eval-test-rule-id branch November 6, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant