Repository navigation
build: give jpackage a Windows/Linux app icon - #7773
Merged
Merged
Conversation
jpackage never passed --icon, so only macOS (which picks up PcGen.icns from resourceDir by app-name convention) got the PCGen logo. Windows shortcuts and Linux launchers fell back to the default Java icon. Pass the Vitruvian-man logo explicitly per platform: PCGenIcon.ico on Windows and PCGenApp.png on Linux. macOS is unchanged.
Contributor
🚧 PCGen Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Windows and Linux packages show jpackage's generic Java icon because the build does not pass
--icon. This change supplies the application icon when creating the app image.installers/win-installer/Local/PCGen2.ico, restoring the gold Vitruvian-man artwork used by the previous Windows installer for desktop and Start menu shortcuts.code/src/images/PCGenApp.png.PcGen.icnsfrominstallers/mac-installer.Validation:
./gradlew fullJpackage --dry-run --offlinepassed with Temurin 25 and stored a configuration-cache entry.git diff --checkpassed. The Windows asset was visually inspected and confirmed against the legacy installer's shortcut configuration; both icon assets have the required file formats.Native Windows/Linux installer builds and visual checks of the installed shortcuts are still needed. The macOS dry run does not execute those platform branches, and the regular PR CI does not build native installers.