You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PEtab v2 spec reserves the following keywords (case-insensitive), which must not be used as identifiers (Reserved keywords):
true, false
inf
time
nan
PEtab math function names
libpetab currently does not check this. _valid_petab_id (petab/v2/core.py) only checks the identifier pattern via petab.v1.lint.is_valid_identifier, so, e.g., a parameter, observable, or condition target with ID time or Exp is accepted. Some of these cases are currently caught only incidentally (e.g., with #588, a parameter time is reported as extraneous), others not at all.
To be decided where to check this:
Pydantic validation in _valid_petab_id / _valid_petab_id_or_none: catches it on construction for all PEtab tables. is_valid_identifier is shared with v1, whose spec has no such list, so this would need a v2-specific check.
A ValidationTask in petab/v2/lint.py: reports all occurrences at once instead of failing on the first one, and can also cover model entity IDs (e.g., an SBML parameter time), which Pydantic validation of the PEtab tables can't.
Possibly both: Pydantic for the PEtab tables, a lint task for the model.
Activity