Skip to content

Write and lint hybridization target values as PEtab math - #590

Merged
dweindl merged 1 commit into
PEtab-dev:mainfrom
dweindl:fix-sciml-target-value-str
Nov 16, 2026
Merged

dweindl merged 1 commit into
PEtab-dev:mainfrom
dweindl:fix-sciml-target-value-str

Conversation

@dweindl

@dweindl dweindl commented Nov 16, 2026

Copy link
Copy Markdown
Member

HybridizationTable.to_df (and thus to_tsv) and the target value check in CheckHybridizationTable converted target values with str(), which produces sympy syntax that is not valid PEtab math, e.g. x**2.0 for x^2 or Abs(y) for abs(y). Written hybridization tables therefore could not be read again, and the linter reported valid target values as invalid. Both now use petab_math_str.

Relates to #584, which makes this more common, since Boolean target values like x > 0 become Piecewise expressions.

🤖 Generated with Claude Code

`HybridizationTable.to_df` and the target value check in
`CheckHybridizationTable` used `str()`, which gives sympy syntax, e.g.
`x**2.0` or `Abs(y)`, that is not valid PEtab math. As a result,
written hybridization tables could not be read again, and the linter
reported valid target values as invalid. Use `petab_math_str` instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.52%. Comparing base (ec0d6c1) to head (2dc23d0).

Files with missing lines Patch % Lines
petab/v2/extensions/sciml.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   79.50%   79.52%   +0.01%     
==========================================
  Files          70       70              
  Lines        8274     8277       +3     
  Branches     1496     1498       +2     
==========================================
+ Hits         6578     6582       +4     
+ Misses       1206     1204       -2     
- Partials      490      491       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
dweindl marked this pull request as ready for review November 16, 2026 14:07
@dweindl
dweindl requested a review from a team as a code owner November 16, 2026 14:07
@dweindl dweindl self-assigned this Nov 16, 2026

@dilpath dilpath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dweindl
dweindl merged commit e9de650 into PEtab-dev:main Nov 16, 2026
7 checks passed
@dweindl
dweindl deleted the fix-sciml-target-value-str branch November 16, 2026 19:31
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
…v#600)

Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its changelog entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At
release time, `towncrier build --version X.Y.Z` collects them into
`CHANGELOG.md` and removes the fragments. The template in
`changelog.d/template.md.j2` reproduces the existing format (`**Fixes**`
etc., `* ` bullets with 2-space continuation lines). Entries are sorted
alphabetically within each category; grouping them (e.g., by PEtab
version or module) is done when compiling the release notes. The
configuration is in `pyproject.toml`, and towncrier is added to the
`test` dependency group. The release process in `doc/development.rst` is
updated accordingly.

Entries now link to the pull request only, without "by @user";
contributors can be credited in the release notes.

The unreleased 0.11.0 entry (PEtab-dev#578) is moved to `changelog.d/`, and
entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did
not add one. The behaviour changes from PEtab-dev#584 (top-level Boolean
expressions are returned as `Piecewise`) and PEtab-dev#592 (stricter
`PySBModel.pattern_from_string`) are listed as breaking changes.

Open pull requests that edit `CHANGELOG.md` will need to move their
entry to a fragment file.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants