Repository navigation
Write and lint hybridization target values as PEtab math - #590
Merged
Merged
Conversation
`HybridizationTable.to_df` and the target value check in `CheckHybridizationTable` used `str()`, which gives sympy syntax, e.g. `x**2.0` or `Abs(y)`, that is not valid PEtab math. As a result, written hybridization tables could not be read again, and the linter reported valid target values as invalid. Use `petab_math_str` instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
+ Coverage 79.50% 79.52% +0.01%
==========================================
Files 70 70
Lines 8274 8277 +3
Branches 1496 1498 +2
==========================================
+ Hits 6578 6582 +4
+ Misses 1206 1204 -2
- Partials 490 491 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
…v#600) Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its changelog entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md` and removes the fragments. The template in `changelog.d/template.md.j2` reproduces the existing format (`**Fixes**` etc., `* ` bullets with 2-space continuation lines). Entries are sorted alphabetically within each category; grouping them (e.g., by PEtab version or module) is done when compiling the release notes. The configuration is in `pyproject.toml`, and towncrier is added to the `test` dependency group. The release process in `doc/development.rst` is updated accordingly. Entries now link to the pull request only, without "by @user"; contributors can be credited in the release notes. The unreleased 0.11.0 entry (PEtab-dev#578) is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. The behaviour changes from PEtab-dev#584 (top-level Boolean expressions are returned as `Piecewise`) and PEtab-dev#592 (stricter `PySBModel.pattern_from_string`) are listed as breaking changes. Open pull requests that edit `CHANGELOG.md` will need to move their entry to a fragment file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HybridizationTable.to_df(and thusto_tsv) and the target value check inCheckHybridizationTableconverted target values withstr(), which produces sympy syntax that is not valid PEtab math, e.g.x**2.0forx^2orAbs(y)forabs(y). Written hybridization tables therefore could not be read again, and the linter reported valid target values as invalid. Both now usepetab_math_str.Relates to #584, which makes this more common, since Boolean target values like
x > 0becomePiecewiseexpressions.🤖 Generated with Claude Code