Repository navigation
Fix PySBModel.is_state_variable for species with binding sites - #592
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 79.52% 79.71% +0.18%
==========================================
Files 70 70
Lines 8277 8315 +38
Branches 1498 1506 +8
==========================================
+ Hits 6582 6628 +46
+ Misses 1204 1198 -6
+ Partials 491 489 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fix_pysb_is_state_variable
branch
2 times, most recently
from
November 16, 2026 14:55
b77af04 to
68cf525
Compare
dweindl
marked this pull request as ready for review
November 16, 2026 15:03
dilpath
approved these changes
Nov 16, 2026
`is_state_variable` raised `KeyError` for any species with a site without states, and didn't recognize `(state, bond)` tuples or `MultiState`. This broke PEtab v2 linting for PySB problems with such species as condition targets. `pattern_from_string` now parses the species name via `ast` and builds the pattern from the model's monomers and compartments. `is_state_variable` checks that all sites are specified and all bonds are paired. Compartments remain optional. Fixes PEtab-dev#585. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
fix_pysb_is_state_variable
branch
from
November 16, 2026 18:09
68cf525 to
0c44294
Compare
dweindl
enabled auto-merge (squash)
November 16, 2026 18:12
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
…v#600) Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its changelog entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md` and removes the fragments. The template in `changelog.d/template.md.j2` reproduces the existing format (`**Fixes**` etc., `* ` bullets with 2-space continuation lines). Entries are sorted alphabetically within each category; grouping them (e.g., by PEtab version or module) is done when compiling the release notes. The configuration is in `pyproject.toml`, and towncrier is added to the `test` dependency group. The release process in `doc/development.rst` is updated accordingly. Entries now link to the pull request only, without "by @user"; contributors can be credited in the release notes. The unreleased 0.11.0 entry (PEtab-dev#578) is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. The behaviour changes from PEtab-dev#584 (top-level Boolean expressions are returned as `Piecewise`) and PEtab-dev#592 (stricter `PySBModel.pattern_from_string`) are listed as breaking changes. Open pull requests that edit `CHANGELOG.md` will need to move their entry to a fragment file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySBModel.is_state_variableraisedKeyErrorfor any species with a site without states, so PEtab v2 linting crashed for PySB problems that use such species as condition targets. It also didn't recognize(state, bond)tuples,MultiState, lists of bonds, or complex-level compartments ((A(b=1) % B(a=1)) ** c).pattern_from_stringnow parses the species name viaast(noeval) and builds the pattern from the model's monomers and compartments. Invalid names raiseValueErrorthat includes the offending string.is_state_variablechecks that all sites are specified and all bonds are paired.pattern_from_stringis stricter than before: unknown monomers, sites, states, or compartments now raiseValueErrorinstead of producing a pattern with missing components.Limitations (documented): compartments are still optional for models with compartments, and it is not checked whether the species is actually generated by the model or whether the monomers of a complex are connected.
Fixes #585.
🤖 Generated with Claude Code