Skip to content

ExperimentsToSbmlConverter: map time to the SBML time csymbol - #595

Merged
dweindl merged 2 commits into
PEtab-dev:mainfrom
dweindl:fix_589_time_csymbol
Nov 16, 2026
Merged

dweindl merged 2 commits into
PEtab-dev:mainfrom
dweindl:fix_589_time_csymbol

Conversation

@dweindl

@dweindl dweindl commented Nov 16, 2026

Copy link
Copy Markdown
Member

time in condition target values was added to the converted SBML model as a constant parameter with value 0. It is now converted to the SBML time csymbol, both in event assignments (later periods) and in initial assignments (first period). Csymbols are no longer added as missing parameters.

Fixes #589.

🤖 Generated with Claude Code

@codecov-commenter

codecov-commenter commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.75%. Comparing base (335ba47) to head (e57d616).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
petab/v2/converters.py 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   79.71%   79.75%   +0.04%     
==========================================
  Files          70       70              
  Lines        8315     8332      +17     
  Branches     1506     1510       +4     
==========================================
+ Hits         6628     6645      +17     
+ Misses       1198     1197       -1     
- Partials      489      490       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Nov 16, 2026
Previously, `time` in condition target values was added to the model
as a constant parameter with value 0. Now it is converted to the SBML
time csymbol in event assignments and initial assignments, and
csymbols are skipped when adding missing parameters.

Fixes PEtab-dev#589.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dweindl
dweindl force-pushed the fix_589_time_csymbol branch from 2cd3222 to 2105681 Compare November 16, 2026 19:21
@dweindl
dweindl marked this pull request as ready for review November 16, 2026 19:30
@dweindl
dweindl requested a review from a team as a code owner November 16, 2026 19:30
Comment thread petab/v2/converters.py Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dweindl
dweindl enabled auto-merge November 16, 2026 20:56
@dweindl
dweindl added this pull request to the merge queue Nov 16, 2026
Merged via the queue into PEtab-dev:main with commit 7580974 Nov 16, 2026
8 checks passed
@dweindl
dweindl deleted the fix_589_time_csymbol branch November 16, 2026 21:03
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release
time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`.

The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are
added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Nov 17, 2026
…v#600)

Every pull request added its changelog entry at the same place in
`CHANGELOG.md`, so concurrent pull requests conflicted with each other.

Now, each pull request adds its changelog entry as a separate file
`changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At
release time, `towncrier build --version X.Y.Z` collects them into
`CHANGELOG.md` and removes the fragments. The template in
`changelog.d/template.md.j2` reproduces the existing format (`**Fixes**`
etc., `* ` bullets with 2-space continuation lines). Entries are sorted
alphabetically within each category; grouping them (e.g., by PEtab
version or module) is done when compiling the release notes. The
configuration is in `pyproject.toml`, and towncrier is added to the
`test` dependency group. The release process in `doc/development.rst` is
updated accordingly.

Entries now link to the pull request only, without "by @user";
contributors can be credited in the release notes.

The unreleased 0.11.0 entry (PEtab-dev#578) is moved to `changelog.d/`, and
entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did
not add one. The behaviour changes from PEtab-dev#584 (top-level Boolean
expressions are returned as `Piecewise`) and PEtab-dev#592 (stricter
`PySBModel.pattern_from_string`) are listed as breaking changes.

Open pull requests that edit `CHANGELOG.md` will need to move their
entry to a fragment file.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExperimentsToSbmlConverter: time in condition target values becomes a constant parameter

3 participants